From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 108C3C433E3 for ; Wed, 19 Aug 2020 10:44:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB3FF2076E for ; Wed, 19 Aug 2020 10:44:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MuIATdYH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3FF2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8LZZ-0001Qw-Up for qemu-devel@archiver.kernel.org; Wed, 19 Aug 2020 06:44:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8LYX-0000xT-25 for qemu-devel@nongnu.org; Wed, 19 Aug 2020 06:42:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44524 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k8LYQ-0002sB-Dg for qemu-devel@nongnu.org; Wed, 19 Aug 2020 06:42:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597833769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a5le+NVoYEZoOj6S0s23X8W1dIquHC2Lc/K1l9mRcsE=; b=MuIATdYHrUg5nWkS/QOpIjLiDhwYhMeVnB9WDOXpmX3mOpFBMH+n6Op5rgyvO+vZ0DiISO B6ZBLNO5VduFfomFXG1yvqHB3j+7gjXiKChfCwAN/lFFvc40zlKNwHFwAAWPrd+4cYhvHh a2EgRiOj5h/udiCrElFlYa8ioPO22is= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-PayXdbPPMH2YFNysRIwUhw-1; Wed, 19 Aug 2020 06:42:47 -0400 X-MC-Unique: PayXdbPPMH2YFNysRIwUhw-1 Received: by mail-wm1-f72.google.com with SMTP id c184so620408wme.1 for ; Wed, 19 Aug 2020 03:42:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a5le+NVoYEZoOj6S0s23X8W1dIquHC2Lc/K1l9mRcsE=; b=heMZIqTOjTa6YxLdtuiI/xtDmVpNkDJMaDXTVmw/QPmNiSxuB64QqlkSlqdxWMPQzW X1A27W9+HmGId+24iFZbxtL2PaBU9cfeAsO5zqacs0VyRKBX17NlUcefjoQ/xR7Ngga4 kFR9tvHNcEuSkceTnapW45RiCtzKJ9Hr6ZkeLZoLzVcgM7PmDQcRA5NiLpwg83C5lnME 4p4utsaLuYbcyGIkgklcTlYJhynmoqC6wn13JQGvDcug5TixltAtxF0rz5dObJwhKTHX 95MRIqmzVcBgolpKmd8oB9cUsCLUS/dNKdqVdzNwFwreCQDLSTZ7RU20oH50RlRF/vkq p8Cw== X-Gm-Message-State: AOAM532FXeeIbF09/2RU0YLX7YlFNtIuNfBrcNJLKOs0hXZXQRmeu72B YNCB3YHUaqMU3xqpZ5MgZXRY6IjgJ7q/d9yzKwWwDaOiff7GTupEp1+8s9cHnGRolNYhZvm2bSt LjkExnJEQIkrg6po= X-Received: by 2002:adf:f64f:: with SMTP id x15mr26083204wrp.180.1597833766258; Wed, 19 Aug 2020 03:42:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNGK4Wb/2+LoUCkyxvOFU/4RsaY7cpGX/hXlhIm5JJL5Q3dgbQCyXwvPi5fCDQ8F/Nb9TJFg== X-Received: by 2002:adf:f64f:: with SMTP id x15mr26083183wrp.180.1597833765964; Wed, 19 Aug 2020 03:42:45 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:1cc0:4e4e:f1a9:1745? ([2001:b07:6468:f312:1cc0:4e4e:f1a9:1745]) by smtp.gmail.com with ESMTPSA id w10sm5282556wmk.0.2020.08.19.03.42.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2020 03:42:45 -0700 (PDT) Subject: Re: [PATCH] tests: docker: support mxe-based mingw builds To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20200819080206.27423-1-pbonzini@redhat.com> <20200819082013.GB69261@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 19 Aug 2020 12:42:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200819082013.GB69261@redhat.com> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=pbonzini@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/19 04:00:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 19/08/20 10:20, Daniel P. Berrangé wrote: > We already have docker containers with MXE based on Debian: > > debian-win32-cross.docker > debian-win64-cross.docker > > your image uses a different naming convention, and puts both > 32 and 64 bit in the same image. Yeah, that's what test-mingw expects. > I feel like we should have the Ubuntu variant follow the same > structure and naming as the Debian variant for consistency. My patch follows the Fedora variant, so that test-mingw runs. That ensures that NSIS is covered as well. One possibility could be: - create fedora-win*-cross dockerfiles - add ENV FEATURES $FEATURES mingw to the win*-cross dockerfiles - look for the feature in test-full and test-quick, and run "make installer" if so. - drop test-mingw completely, and adjust Patchew to use docker-test-quick@fedora-win{32,64}-cross instead Paolo