From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Sergey Kambalin <serg.oker@gmail.com>, qemu-devel@nongnu.org
Cc: Sergey Kambalin <sergey.kambalin@auriga.com>
Subject: Re: [PATCH] Make bootable RPi4B model
Date: Mon, 3 Apr 2023 08:51:11 +0200 [thread overview]
Message-ID: <a83dd975-2270-1be6-0264-516badbacc38@linaro.org> (raw)
In-Reply-To: <20230402165306.137092-1-sergey.kambalin@auriga.com>
Hi Sergey,
On 2/4/23 18:53, Sergey Kambalin wrote:
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
> configs/devices/aarch64-softmmu/default.mak | 1 +
> hw/arm/Kconfig | 7 +
> hw/arm/bcm2835_peripherals.c | 218 ++++++----
> hw/arm/bcm2836.c | 129 +++---
> hw/arm/bcm2838.c | 294 ++++++++++++++
> hw/arm/bcm2838_pcie.c | 300 ++++++++++++++
> hw/arm/bcm2838_peripherals.c | 262 ++++++++++++
> hw/arm/meson.build | 6 +
> hw/arm/raspi.c | 128 +++---
> hw/arm/raspi4b.c | 232 +++++++++++
> hw/arm/trace-events | 6 +
> hw/gpio/bcm2838_gpio.c | 395 ++++++++++++++++++
> hw/gpio/meson.build | 1 +
> hw/misc/bcm2835_property.c | 318 ++++++++++++---
> hw/misc/bcm2838_rng200.c | 421 ++++++++++++++++++++
> hw/misc/bcm2838_thermal.c | 97 +++++
> hw/misc/meson.build | 4 +
> hw/misc/trace-events | 10 +
> include/hw/arm/bcm2835_peripherals.h | 29 +-
> include/hw/arm/bcm2836.h | 30 +-
> include/hw/arm/bcm2838.h | 26 ++
> include/hw/arm/bcm2838_pcie.h | 67 ++++
> include/hw/arm/bcm2838_peripherals.h | 56 +++
> include/hw/arm/raspi4b_platform.h | 54 +++
> include/hw/arm/raspi_platform.h | 34 ++
> include/hw/display/bcm2835_fb.h | 2 +
> include/hw/gpio/bcm2838_gpio.h | 45 +++
> include/hw/misc/bcm2838_rng200.h | 77 ++++
> include/hw/misc/bcm2838_thermal.h | 24 ++
> include/hw/misc/raspberrypi-fw-defs.h | 169 ++++++++
> 30 files changed, 3175 insertions(+), 267 deletions(-)
The patch subject sounds promising! However 3175 lines of
code to review is a bit hardcore... Could you split your
patch per device (at least)?
Ideally one patch should contain a single logical change.
Also, can you provide how you tested your patch?
Thanks,
Phil.
next prev parent reply other threads:[~2023-04-03 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 16:53 [PATCH] Make bootable RPi4B model Sergey Kambalin
2023-04-03 6:51 ` Philippe Mathieu-Daudé [this message]
2023-04-03 7:21 ` Kambalin, Sergey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a83dd975-2270-1be6-0264-516badbacc38@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=serg.oker@gmail.com \
--cc=sergey.kambalin@auriga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).