From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7B2C433E0 for ; Thu, 4 Mar 2021 13:58:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D84F664EBB for ; Thu, 4 Mar 2021 13:58:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D84F664EBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHoUv-0004jZ-19 for qemu-devel@archiver.kernel.org; Thu, 04 Mar 2021 08:58:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHoTI-00045R-Hk for qemu-devel@nongnu.org; Thu, 04 Mar 2021 08:56:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHoTE-0000rY-4H for qemu-devel@nongnu.org; Thu, 04 Mar 2021 08:56:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614866207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MpHX/a7yCBReDRTGDYwwyxBKDLq55HbfjE9ITkwtBBE=; b=gzCsrWqSVBsJ0KZrmgOpfTApoFKqOs+7yMsbQVv4PW/SSWLtqnKKomeDtaENltp1w8+CCs Iclf5oZw3UbgotSQ3uSAbeiJM7XAgEuWURbfgo8iyb3hFZzBDveSUVFKTRP69SbVqYKQfa 7k8IN/bEi3qqwWJgf+AmbDb0FvZSUeA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-rPLNkA1rOVupy0TyKKY34w-1; Thu, 04 Mar 2021 08:56:46 -0500 X-MC-Unique: rPLNkA1rOVupy0TyKKY34w-1 Received: by mail-wm1-f69.google.com with SMTP id n17so2569795wmi.2 for ; Thu, 04 Mar 2021 05:56:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MpHX/a7yCBReDRTGDYwwyxBKDLq55HbfjE9ITkwtBBE=; b=LoeP4PXoDcpszX/6FwgX6xfFOQUAu70v+/qrCrSjy+MRWM2OjXP3rK+eu6WOgnROoV GmT66PyJNMQzI/ix6SC+/AB5NYWZq15YylYgArKaRPn3rt+qhOUBEOsyn5Qu69gDUmYx RA0cI8uJKE3xkn7YFlGjGhfaz2oFaPboZVUL4ElURdDveuJ7F5Vkz+ojnQ/clk+kbAAa vFXHZ7J0U1uInrWAVascVkebua0mhhDELTS4mAAVQKl5wVQ0rcW2b/wF+HsM7x+JOUdh dOouKz2f3zDFQmuKqyzzCjf1SKainJEu8+9unKKwKH80xa5pIITkSxg1VAbT94/qNptP mp1Q== X-Gm-Message-State: AOAM533xJj+b7StmddJ99MXc0efTsEJXvHsGP/jsYN0W/EuJuMTNtty7 BjgCfxxCROzU8F3idkb9bxANUJ/TR2b6LLEz5FdIFrNNxiG6kBrSVEhO3/3EhqsMvGfqV9qi0Yk 8/Sy1XRdefmyYYdM= X-Received: by 2002:a7b:c041:: with SMTP id u1mr4049880wmc.161.1614866204899; Thu, 04 Mar 2021 05:56:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYGR8bnjcT7LzAXU8tRW/khqIFgYtcWtTCkFEJV0OxsrH10KzYftCakpHiJpw9Zqs1Dxhs7Q== X-Received: by 2002:a7b:c041:: with SMTP id u1mr4049856wmc.161.1614866204738; Thu, 04 Mar 2021 05:56:44 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h20sm9649878wmp.38.2021.03.04.05.56.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 05:56:44 -0800 (PST) Subject: Re: [RFC PATCH 00/19] accel: Introduce AccelvCPUState opaque structure To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210303182219.1631042-1-philmd@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 4 Mar 2021 14:56:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210303182219.1631042-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , haxm-team@intel.com, Colin Xu , Halil Pasic , Christian Borntraeger , Claudio Fontana , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Sunil Muthuswamy , David Gibson , Marcelo Tosatti , Roman Bolshakov , qemu-ppc@nongnu.org, Wenchao Wang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/03/21 19:22, Philippe Mathieu-Daudé wrote: > Series is organized as: > - preliminary trivial cleanups > - introduce AccelvCPUState > - move WHPX fields (build-tested) > - move HAX fields (not tested) > - move KVM fields (build-tested) > - move HVF fields (not tested) This approach prevents adding a TCG state. Have you thought of using a union instead, or even a void pointer? Paolo