From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT4ev-0006OY-HN for qemu-devel@nongnu.org; Wed, 13 Jun 2018 08:13:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT4eu-0005K7-Jl for qemu-devel@nongnu.org; Wed, 13 Jun 2018 08:13:53 -0400 References: <20180611011501.10235-1-f4bug@amsat.org> <20180611011501.10235-12-f4bug@amsat.org> <15d222dd-d2e9-4855-62c6-f89f2ee59c52@linaro.org> <76aa5170-1d18-8799-6ff1-a7c0dba0b489@redhat.com> <8537ca07-2645-6c2c-5945-a91da035b474@linaro.org> From: Eric Blake Message-ID: Date: Wed, 13 Jun 2018 07:13:43 -0500 MIME-Version: 1.0 In-Reply-To: <8537ca07-2645-6c2c-5945-a91da035b474@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Thomas Huth , Stefan Weil Cc: Kevin Wolf , Stefano Stabellini , Eduardo Habkost , "open list:Block layer core" , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini , Anthony Perard , "open list:X86" , Richard Henderson On 06/12/2018 04:10 PM, Richard Henderson wrote: >> So there's tradeoffs either way, and you at least need to document in your >> commit messages what auditing you have done that any type changes introduced by >> your changes are safe. > > I'm more concerned about unnecessary or unintended signed vs unsigned changes > than I am about width. But if we're going to force a 64-bit type, use > (int64_t)1 not 1LL. That way the type will match the existing PRId64 printf > markup. Or spell it UINT64_C(1) if you don't want a cast. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org