From: Evan Goldenberg <evangoldenberg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set
Date: Fri, 12 Jun 2009 16:51:13 -0400 [thread overview]
Message-ID: <a8624900906121351j6cfa42d6t34a222630dafec99@mail.gmail.com> (raw)
The MBAR offset for the UART2 output port bit set function on the
an5206 board, though unimplemented, is incorrectly defined as 0x1c8.
The correct offset used by the hardware for this function is 0x1b8.
This typo causes QEMU to crash whenever attempts to access use UART2
are made:
qemu: fatal: Bad MBAR write offset 0x1b8
The following patch resolves this issue.
diff --git a/hw/mcf5206.c b/hw/mcf5206.c
index b570376..8bf11a4 100644
--- a/hw/mcf5206.c
+++ b/hw/mcf5206.c
@@ -341,7 +341,7 @@ static void m5206_mbar_write(m5206_mbar_state *s,
uint32_t offset,
case 0x170:
s->uivr[0] = value;
break;
- case 0x178: case 0x17c: case 0x1c8: case 0x1bc:
+ case 0x178: case 0x17c: case 0x1b8: case 0x1bc:
/* Not implemented: UART Output port bits. */
break;
case 0x1b0:
next reply other threads:[~2009-06-12 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 20:51 Evan Goldenberg [this message]
2009-06-13 22:15 ` [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8624900906121351j6cfa42d6t34a222630dafec99@mail.gmail.com \
--to=evangoldenberg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).