qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event
Date: Wed, 17 Oct 2018 08:54:23 -0500	[thread overview]
Message-ID: <a8739a07-0675-5e16-b357-6bb2179aed11@redhat.com> (raw)
In-Reply-To: <d2f89cb6-0ea5-75bc-1bb1-3f0ce6509ec4@redhat.com>

On 10/17/18 5:58 AM, Paolo Bonzini wrote:

>> -        qapi_event_send_shutdown(shutdown_caused_by_guest(request));
>> +        qapi_event_send_shutdown(shutdown_caused_by_guest(request),
>> +                                 shutdown_was_reset);
> 
> So the problem with shutdown_caused_by_guest is that you get the same
> value for both guest reset and guest shutdown.  Could we instead just
> pass the ShutdownCause in the event (similar to what was proposed even
> when discussing commit 08fba7ac9b618516a5f1d096f78a7e2837fe0594)?

Indeed, it sounds like we are now at the point where we want to do 
precisely that - expose more fine-grained details by adding 
ShutdownCause as a QAPI enum, rather than just adding another bool per 
reason.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  parent reply	other threads:[~2018-10-17 13:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 13:19 [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event Dominik Csapak
2018-10-17  7:17 ` Dominik Csapak
2018-10-17 10:58   ` Paolo Bonzini
2018-10-17 11:34     ` Dominik Csapak
2018-10-17 11:36       ` Paolo Bonzini
2018-10-17 13:54     ` Eric Blake [this message]
2018-10-17 14:43       ` Paolo Bonzini
2018-10-23  7:51         ` Dominik Csapak
2018-10-17 13:51   ` Eric Blake
2018-10-17 14:02     ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8739a07-0675-5e16-b357-6bb2179aed11@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).