From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning
Date: Tue, 20 Dec 2022 15:58:41 +0100 [thread overview]
Message-ID: <a87d9439-5ac3-aa95-4757-994d828df2a1@linaro.org> (raw)
In-Reply-To: <Y6HJ21W6Q5h2UvrE@redhat.com>
On 20/12/22 15:42, Daniel P. Berrangé wrote:
> On Tue, Dec 20, 2022 at 03:35:29PM +0100, Philippe Mathieu-Daudé wrote:
>> Silent few -Wmissing-field-initializers warnings enabled by -Wextra.
>>
>> Philippe Mathieu-Daudé (3):
>> tcg: Silent -Wmissing-field-initializers warning
>> accel/kvm: Silent -Wmissing-field-initializers warning
>> softmmu: Silent -Wmissing-field-initializers warning
>>
>> accel/kvm/kvm-all.c | 4 ++--
>> softmmu/vl.c | 2 +-
>> tcg/tcg-common.c | 2 +-
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> If we're going to the trouble of fixing violations (which is
> good), then we shouuld also add -Wmissing-field-initializers
> (or -Wextra) to warn_flags in configure, to prevent regressions
> again in future.
Yes, I plan to add it at the end. I choose to split in small
contained series to avoid spamming every maintainers, but this
is actually that trivial that I could have sent as a big one...
Thanks for the review!
prev parent reply other threads:[~2022-12-20 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 14:35 [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning Philippe Mathieu-Daudé
2022-12-20 14:35 ` [PATCH 1/3] tcg: Silent " Philippe Mathieu-Daudé
2022-12-20 14:43 ` Daniel P. Berrangé
2022-12-20 14:35 ` [PATCH 2/3] accel/kvm: " Philippe Mathieu-Daudé
2022-12-20 14:44 ` Daniel P. Berrangé
2022-12-20 14:35 ` [PATCH 3/3] softmmu: " Philippe Mathieu-Daudé
2022-12-20 14:44 ` Daniel P. Berrangé
2022-12-20 14:42 ` [PATCH 0/3] accel: Silent few " Daniel P. Berrangé
2022-12-20 14:58 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a87d9439-5ac3-aa95-4757-994d828df2a1@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).