From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation
Date: Mon, 10 Feb 2025 15:26:00 +0100 [thread overview]
Message-ID: <a8855d03-d207-4a0d-a16f-24e4436a3b66@linaro.org> (raw)
In-Reply-To: <F8650CD9-AA03-4462-A74E-7A068820F1A2@gmail.com>
On 6/2/25 22:58, Bernhard Beschow wrote:
>
>
> Am 6. Februar 2025 17:32:31 UTC schrieb Peter Maydell <peter.maydell@linaro.org>:
>> On Tue, 4 Feb 2025 at 09:21, Bernhard Beschow <shentey@gmail.com> wrote:
>>>
>>> The implementation just allows Linux to determine date and time.
>>>
>>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>>> ---
>>> MAINTAINERS | 1 +
>>> hw/rtc/rs5c372.c | 227 ++++++++++++++++++++++++++++++++++++++++++++
>>> hw/rtc/Kconfig | 5 +
>>> hw/rtc/meson.build | 1 +
>>> hw/rtc/trace-events | 4 +
>>> 5 files changed, 238 insertions(+)
>>> create mode 100644 hw/rtc/rs5c372.c
>>
>> Should there be a patch after this one that adds this device
>> to your board ?
>
> As per Kconfig the board selects I2C_DEVICES and this device is "default y if I2C_DEVICES". I've deliberately not hardcoded this device to the board to make it emulate a plain i.MX 8M Plus SoC (see also board documentation).
Then maybe add a test to be sure it is not bitroting?
next prev parent reply other threads:[~2025-02-10 14:26 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:20 [PATCH v2 00/18] Add i.MX 8M Plus EVK machine Bernhard Beschow
2025-02-04 9:20 ` [PATCH v2 01/18] hw/usb/hcd-dwc3: Align global registers size with Linux Bernhard Beschow
2025-02-04 9:20 ` [PATCH v2 02/18] hw/pci-host/designware: Prevent device attachment on internal PCIe root bus Bernhard Beschow
2025-02-17 13:36 ` Peter Maydell
2025-02-04 9:20 ` [PATCH v2 03/18] hw/gpio/pca955*: Move Kconfig switches next to implementations Bernhard Beschow
2025-02-17 13:35 ` Peter Maydell
2025-02-17 19:39 ` Bernhard Beschow
2025-02-18 10:33 ` Peter Maydell
2025-02-19 21:43 ` Bernhard Beschow
2025-02-04 9:20 ` [PATCH v2 04/18] hw/arm: Add i.MX 8M Plus EVK board Bernhard Beschow
2025-02-10 17:30 ` Peter Maydell
2025-02-10 22:44 ` Bernhard Beschow
2025-02-11 10:06 ` Peter Maydell
2025-02-11 23:40 ` Bernhard Beschow
2025-02-23 11:40 ` Bernhard Beschow
2025-02-04 9:20 ` [PATCH v2 05/18] hw/arm/fsl-imx8mp: Implement clock tree Bernhard Beschow
2025-02-04 23:15 ` Bernhard Beschow
2025-02-04 9:21 ` [PATCH v2 06/18] hw/arm/fsl-imx8mp: Add SNVS Bernhard Beschow
2025-02-04 9:21 ` [PATCH v2 07/18] hw/arm/fsl-imx8mp: Add USDHC storage controllers Bernhard Beschow
2025-02-06 17:25 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 08/18] hw/arm/fsl-imx8mp: Add PCIe support Bernhard Beschow
2025-02-17 13:40 ` Peter Maydell
2025-02-17 16:33 ` Bernhard Beschow
2025-02-04 9:21 ` [PATCH v2 09/18] hw/arm/fsl-imx8mp: Add GPIO controllers Bernhard Beschow
2025-02-06 17:26 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 10/18] hw/arm/fsl-imx8mp: Add I2C controllers Bernhard Beschow
2025-02-06 17:26 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 11/18] hw/arm/fsl-imx8mp: Add SPI controllers Bernhard Beschow
2025-02-06 17:26 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 12/18] hw/arm/fsl-imx8mp: Add watchdog support Bernhard Beschow
2025-02-06 17:27 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 13/18] hw/arm/fsl-imx8mp: Implement gneral purpose timers Bernhard Beschow
2025-02-06 17:29 ` Peter Maydell
2025-02-07 8:08 ` Bernhard Beschow
2025-02-04 9:21 ` [PATCH v2 14/18] hw/arm/fsl-imx8mp: Add Ethernet controller Bernhard Beschow
2025-02-06 17:30 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 15/18] hw/arm/fsl-imx8mp: Add USB support Bernhard Beschow
2025-02-06 17:31 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 16/18] hw/arm/fsl-imx8mp: Add boot ROM Bernhard Beschow
2025-02-17 13:28 ` Peter Maydell
2025-02-17 22:48 ` Bernhard Beschow
2025-02-23 11:04 ` Bernhard Beschow
2025-02-04 9:21 ` [PATCH v2 17/18] hw/arm/fsl-imx8mp: Add on-chip RAM Bernhard Beschow
2025-02-06 17:31 ` Peter Maydell
2025-02-04 9:21 ` [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation Bernhard Beschow
2025-02-06 17:32 ` Peter Maydell
2025-02-06 21:58 ` Bernhard Beschow
2025-02-10 14:26 ` Philippe Mathieu-Daudé [this message]
2025-02-10 22:48 ` Bernhard Beschow
2025-02-23 10:57 ` Bernhard Beschow
-- strict thread matches above, loose matches on Subject: below --
2025-02-23 11:46 [PATCH v2 00/18] Add i.MX 8M Plus EVK machine Bernhard Beschow
2025-02-23 11:47 ` [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation Bernhard Beschow
2025-03-04 18:53 ` Bernhard Beschow
2025-03-07 19:18 ` Bernhard Beschow
2025-03-11 7:34 ` Bernhard Beschow
2025-03-11 9:20 ` Philippe Mathieu-Daudé
2025-03-11 15:49 ` Corey Minyard
2025-03-11 16:01 ` Philippe Mathieu-Daudé
2025-03-11 12:18 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8855d03-d207-4a0d-a16f-24e4436a3b66@linaro.org \
--to=philmd@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).