qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 03/16] apic: Stop timer on reset
Date: Sun,  4 Dec 2011 15:46:17 +0100	[thread overview]
Message-ID: <a8905075424fcdd8e99088b2c91f0864b50c73e7.1323009989.git.jan.kiszka@web.de> (raw)
In-Reply-To: <cover.1323009989.git.jan.kiszka@web.de>
In-Reply-To: <cover.1323009989.git.jan.kiszka@web.de>

From: Jan Kiszka <jan.kiszka@siemens.com>

All LVTs are masked on reset, so the timer becomes ineffective. Letting
it tick nevertheless is harmless, but will at least create a spurious
trace event.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/apic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/apic.c b/hw/apic.c
index 8289eef..2644a82 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -528,6 +528,8 @@ void apic_init_reset(DeviceState *d)
     s->initial_count_load_time = 0;
     s->next_time = 0;
     s->wait_for_sipi = 1;
+
+    qemu_del_timer(s->timer);
 }
 
 static void apic_startup(APICState *s, int vector_num)
-- 
1.7.3.4

  parent reply	other threads:[~2011-12-04 14:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04 14:46 [Qemu-devel] [PATCH v2 00/16] uq/master: Introduce basic irqchip support Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 01/16] msi: Generalize msix_supported to msi_supported Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 02/16] kvm: Move kvmclock into hw/kvm folder Jan Kiszka
2011-12-04 14:46 ` Jan Kiszka [this message]
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 04/16] apic: Factor out core for KVM reuse Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 05/16] apic: Open-code timer save/restore Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 06/16] i8259: Factor out core for KVM reuse Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 07/16] ioapic: Convert to memory API Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 08/16] ioapic: Reject non-dword accesses to IOWIN register Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 09/16] ioapic: Factor out core for KVM reuse Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 10/16] memory: Introduce memory_region_init_reservation Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 11/16] kvm: Introduce core services for in-kernel irqchip support Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 12/16] kvm: x86: Establish IRQ0 override control Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 13/16] kvm: x86: Add user space part for in-kernel APIC Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 14/16] kvm: x86: Add user space part for in-kernel i8259 Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 15/16] kvm: x86: Add user space part for in-kernel IOAPIC Jan Kiszka
2011-12-04 14:46 ` [Qemu-devel] [PATCH v2 16/16] kvm: Arm in-kernel irqchip support Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8905075424fcdd8e99088b2c91f0864b50c73e7.1323009989.git.jan.kiszka@web.de \
    --to=jan.kiszka@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).