From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: qemu-devel@nongnu.org, Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
qemu-arm@nongnu.org, Taylor Beebe <taylor.d.beebe@gmail.com>,
Pedro Falcato <pedro.falcato@gmail.com>,
Theo Jehl <theojehl76@gmail.com>,
Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [PATCH 1/1] BootLogoLib: align logo coords to be even
Date: Mon, 17 Jun 2024 13:27:21 +0200 [thread overview]
Message-ID: <a896b9ab-8d49-4ce0-82f0-c40704fe0e1d@linaro.org> (raw)
In-Reply-To: <CAMj1kXEukirF7UZTRbdHCx-ppyX=7Msrwpw-b-OJpV33R8d0=g@mail.gmail.com>
W dniu 17.06.2024 o 10:39, Ard Biesheuvel pisze:
>> If we draw logo at odd coords then BootLogoLib goes into exception and
>> boot process ends:
>>
>> Synchronous Exception at 0x00000101FB943E48
>> PC 0x0101FB943E48 (0x0101FB93F000+0x00004E48) [ 0] QemuVideoDxe.dll
>> PC 0x0101FB943314 (0x0101FB93F000+0x00004314) [ 0] QemuVideoDxe.dll
>> PC 0x0101FB92F798 (0x0101FB92D000+0x00002798) [ 1] ConSplitterDxe.dll
>> PC 0x0101FBA96BC4 (0x0101FBA8E000+0x00008BC4) [ 2] BdsDxe.dll
>> PC 0x0101FF7FDF50 (0x0101FF7F3000+0x0000AF50) [ 3] DxeCore.dll
>>
>> This change resizes logo from 193x58 to 194x58px to make it's sizes
>> even. And if coords are odd then they are bumped a bit to make things
>> work.
>>
>> Signed-off-by: Marcin Juszkiewicz<marcin.juszkiewicz@linaro.org>
> This should be fixed in the SBSA firmware
One coffee was not enough so I sent it to QEMU devel instead of EDK2
devel mailing list...
> unaligned accesses are fine on arm64 as long as they don't target
> device memory. So this likely implies that the framebuffer is
> mapped with device attributes while it should be mapped > normal-non-cacheable.
OK, so need to go through QEMU source now.
prev parent reply other threads:[~2024-06-17 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fcdc0626-a0f7-4796-a05d-2462c896f5ba@bsdio.com>
2024-06-17 8:36 ` [PATCH 1/1] BootLogoLib: align logo coords to be even Marcin Juszkiewicz
2024-06-17 8:39 ` Ard Biesheuvel
2024-06-17 11:27 ` Marcin Juszkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a896b9ab-8d49-4ce0-82f0-c40704fe0e1d@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=ardb+tianocore@kernel.org \
--cc=ardb@kernel.org \
--cc=pedro.falcato@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rebecca@bsdio.com \
--cc=taylor.d.beebe@gmail.com \
--cc=theojehl76@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).