From: Liam Merwick <liam.merwick@oracle.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] block: Remove trailing newline in format used by error_report API
Date: Fri, 28 Feb 2020 13:16:33 +0000 [thread overview]
Message-ID: <a89ccf3d-1d5f-ca0f-0f51-ca207676eea4@oracle.com> (raw)
In-Reply-To: <20200228123637.15160-1-philmd@redhat.com>
On 28/02/2020 12:36, Philippe Mathieu-Daudé wrote:
> The error_report API doesn't want trailing newline characters.
> Remove it, to avoid and error when moving the code around:
>
s/and/an/
> ERROR: Error messages should not contain newlines
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 1bdb9c679d..e466d15914 100644
> --- a/block.c
> +++ b/block.c
> @@ -5994,7 +5994,7 @@ void bdrv_img_create(const char *filename, const char *fmt,
> /* Couldn't open BS, but we have a size, so it's nonfatal */
> warn_reportf_err(local_err,
> "Could not verify backing image. "
> - "This may become an error in future versions.\n");
> + "This may become an error in future versions.");
> local_err = NULL;
> } else if (!bs) {
> /* Couldn't open bs, do not have size */
>
next prev parent reply other threads:[~2020-02-28 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 12:36 [PATCH] block: Remove trailing newline in format used by error_report API Philippe Mathieu-Daudé
2020-02-28 13:16 ` Liam Merwick [this message]
2020-02-28 17:32 ` Markus Armbruster
2020-06-05 14:26 ` Philippe Mathieu-Daudé
2020-06-08 4:45 ` Markus Armbruster
2020-06-08 6:14 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89ccf3d-1d5f-ca0f-0f51-ca207676eea4@oracle.com \
--to=liam.merwick@oracle.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).