From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: jsnow@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] iotests: Fix incomplete type declarations
Date: Wed, 13 May 2020 13:57:45 +0200 [thread overview]
Message-ID: <a8a8e0cc-bc14-9b48-5237-04459141eaf7@redhat.com> (raw)
In-Reply-To: <20200511163529.349329-2-kwolf@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 417 bytes --]
On 11.05.20 18:35, Kevin Wolf wrote:
> We need to fix only a few places so that iotests.py can pass
> mypy --disallow-incomplete-defs, which seems to be a desirable option to
> have enabled in the long run.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-13 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:35 [PATCH 0/2] iotests: Run pylint and mypy in a testcase Kevin Wolf
2020-05-11 16:35 ` [PATCH 1/2] iotests: Fix incomplete type declarations Kevin Wolf
2020-05-13 11:57 ` Max Reitz [this message]
2020-05-11 16:35 ` [PATCH 2/2] iotests: Run pylint and mypy in a testcase Kevin Wolf
2020-05-13 12:14 ` Max Reitz
2020-05-13 14:54 ` Kevin Wolf
2020-05-13 20:56 ` [PATCH 0/2] " John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8a8e0cc-bc14-9b48-5237-04459141eaf7@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).