From: Richard Henderson <richard.henderson@linaro.org>
To: Branislav Brzak <brzakbranislav@gmail.com>, qemu-riscv@nongnu.org
Cc: qemu-devel@nongnu.org, alistair.francis@wdc.com
Subject: Re: [PATCH] target/riscv: Fix froundnx.h nanbox check
Date: Thu, 20 Jun 2024 21:22:30 -0700 [thread overview]
Message-ID: <a8b69391-c60d-4250-97cd-60e1f695c9ab@linaro.org> (raw)
In-Reply-To: <20240608214546.226963-1-brzakbranislav@gmail.com>
On 6/8/24 14:45, Branislav Brzak wrote:
> t/riscv/fpu_helper.c b/target/riscv/fpu_helper.c
> index 871a70a316..91b1a56d10 100644
> --- a/target/riscv/fpu_helper.c
> +++ b/target/riscv/fpu_helper.c
> @@ -676,7 +676,7 @@ uint64_t helper_fround_h(CPURISCVState *env, uint64_t rs1)
>
> uint64_t helper_froundnx_h(CPURISCVState *env, uint64_t rs1)
> {
> - float16 frs1 = check_nanbox_s(env, rs1);
> + float16 frs1 = check_nanbox_h(env, rs1);
> frs1 = float16_round_to_int(frs1, &env->fp_status);
> return nanbox_h(env, frs1);
> }
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-06-21 4:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 21:45 [PATCH] target/riscv: Fix froundnx.h nanbox check Branislav Brzak
2024-06-21 4:20 ` Alistair Francis
2024-06-21 4:22 ` Richard Henderson [this message]
2024-06-21 4:44 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8b69391-c60d-4250-97cd-60e1f695c9ab@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=brzakbranislav@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).