From: Thomas Huth <thuth@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mauro Matteo Cascella" <mcascell@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Bandan Das" <bsd@redhat.com>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Siqi Chen" <coc.cyqh@gmail.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>
Subject: Re: [PATCH v8 0/8] memory: prevent dma-reentracy issues
Date: Tue, 25 Apr 2023 11:46:34 +0200 [thread overview]
Message-ID: <a8d076f3-ac2b-4e1a-8bcc-44bf57a750b2@redhat.com> (raw)
In-Reply-To: <20230421142736.2817601-1-alxndr@bu.edu>
On 21/04/2023 16.27, Alexander Bulekov wrote:
> v7 -> v8:
> - Disable reentrancy checks for bcm2835_property's iomem (Patch 7)
> - Cache DeviceState* in the MemoryRegion to avoid dynamic cast for
> each MemoryRegion access. (Patch 1)
> - Make re-entrancy fatal for debug-builds (Patch 8)
Hi Alexander,
I just put your series into a run with the gitlab-CI and it seems this now
introduced another failure in one of the avocado tests:
https://gitlab.com/thuth/qemu/-/jobs/4171448248#L318
The "IbmPrep40pMachine.test_openbios_and_netbsd" test is failing now.
You can reproduce it manually quite easily:
wget
https://archive.netbsd.org/pub/NetBSD-archive/NetBSD-7.1.2/iso/NetBSD-7.1.2-prep.iso
./qemu-system-ppc -nographic -M 40p -boot d -cdrom NetBSD-7.1.2-prep.iso
Without your patches, this prints out "NetBSD/prep BOOT, Revision 1.9" in
the console, but with your patches, the message does not appear anymore.
Could you please have a look?
Thanks,
Thomas
next prev parent reply other threads:[~2023-04-25 9:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 14:27 [PATCH v8 0/8] memory: prevent dma-reentracy issues Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 1/8] " Alexander Bulekov
2023-04-25 7:32 ` Thomas Huth
2023-04-21 14:27 ` [PATCH v8 2/8] async: Add an optional reentrancy guard to the BH API Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 3/8] checkpatch: add qemu_bh_new/aio_bh_new checks Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 4/8] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 5/8] memory: Allow disabling re-entrancy checking per-MR Alexander Bulekov
2023-04-25 7:41 ` Thomas Huth
2023-04-26 15:59 ` Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 6/8] lsi53c895a: disable reentrancy detection for script RAM Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 7/8] bcm2835_property: disable reentrancy detection for iomem Alexander Bulekov
2023-04-25 7:43 ` Thomas Huth
2023-04-21 14:27 ` [PATCH v8 8/8] memory: abort on re-entrancy in debug builds Alexander Bulekov
2023-04-25 7:44 ` Thomas Huth
2023-04-25 9:46 ` Thomas Huth [this message]
2023-04-26 16:03 ` [PATCH v8 0/8] memory: prevent dma-reentracy issues Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8d076f3-ac2b-4e1a-8bcc-44bf57a750b2@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=bsd@redhat.com \
--cc=coc.cyqh@gmail.com \
--cc=darren.kenny@oracle.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mcascell@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).