From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1afi-00042u-E4 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:08:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1aff-0006AC-5v for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:08:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53086) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1afe-0006A4-W1 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:08:15 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C09BC05683F for ; Tue, 1 Nov 2016 15:08:14 +0000 (UTC) References: <20161017180939.27912-1-mreitz@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 1 Nov 2016 16:08:09 +0100 MIME-Version: 1.0 In-Reply-To: <20161017180939.27912-1-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] main-loop: Suppress I/O thread warning under qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: "Michael S . Tsirkin" On 17/10/2016 20:09, Max Reitz wrote: > We do not want to display the "I/O thread spun" warning for test cases > that run under qtest. The first attempt for this (commit > 01c22f2cdd4fcf02276ea10f48253850a5fd7259) tested whether qtest_enabled() > was true. > > Commit 21a24302e85024dd7b2a151158adbc1f5dc5c4dd correctly recognized > that just testing qtest_enabled() is not sufficient since there are some > tests that do not use the qtest accelerator but just the qtest character > device, and thus replaced qtest_enabled() by qtest_driver(). > > However, there are also some tests that only use the qtest accelerator > and not the qtest chardev; perhaps most notably the bash iotests. > Therefore, we have to check both qtest_enabled() and qtest_driver(). > > Signed-off-by: Max Reitz > --- > main-loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/main-loop.c b/main-loop.c > index 6a7f8d3..889b5bf 100644 > --- a/main-loop.c > +++ b/main-loop.c > @@ -232,7 +232,7 @@ static int os_host_main_loop_wait(int64_t timeout) > if (!timeout && (spin_counter > MAX_MAIN_LOOP_SPIN)) { > static bool notified; > > - if (!notified && !qtest_driver()) { > + if (!notified && !qtest_enabled() && !qtest_driver()) { > fprintf(stderr, > "main-loop: WARNING: I/O thread spun for %d iterations\n", > MAX_MAIN_LOOP_SPIN); > Finally queued, thanks. Paolo