From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 482EBE7717D for ; Fri, 13 Dec 2024 12:42:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tM4zB-0001X9-0C; Fri, 13 Dec 2024 07:41:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tM4z5-0001WZ-BX for qemu-devel@nongnu.org; Fri, 13 Dec 2024 07:41:33 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tM4z0-0007k7-5b for qemu-devel@nongnu.org; Fri, 13 Dec 2024 07:41:30 -0500 Received: from zero.eik.bme.hu (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 5E6F24E6109; Fri, 13 Dec 2024 13:41:23 +0100 (CET) X-Virus-Scanned: amavisd-new at eik.bme.hu Received: from zero.eik.bme.hu ([127.0.0.1]) by zero.eik.bme.hu (zero.eik.bme.hu [127.0.0.1]) (amavisd-new, port 10028) with ESMTP id MccK-67Zt98S; Fri, 13 Dec 2024 13:41:21 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 1EFD94E6108; Fri, 13 Dec 2024 13:41:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 1CF55746F60; Fri, 13 Dec 2024 13:41:21 +0100 (CET) Date: Fri, 13 Dec 2024 13:41:21 +0100 (CET) From: BALATON Zoltan To: qemu-devel@nongnu.org cc: Peter Maydell , philmd@linaro.org Subject: Re: [PATCH v2 0/2] Separate memory access logs from guest_errors In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, 2 Nov 2024, BALATON Zoltan wrote: > Originally memory access logs were a debug define that then were > converted to log messages but were classified as guest_errors which > already logs misc errors. As invalid memory access logs can come from > accessing not emulated peripherals or memory areas, these often > generate a lot of messages that are better be controlled separately > from other errors to avoid obscuring those. As an example try > 'qemu-system-ppc -d guest_errors' to see the problem. After this > series the actual guest error logs are easier to spot. I've tried to > submit this before but there were some people who liked the current > behaviour so now this series has another patch that preserves the old > option printing a warning to allow time to get used to the new > behaviour (which actually brings back the old behaviour when mem > access logs were a debug define). This second patch is optional if > changing the behaviour without notice is acceptable. As these are > debug switches no deprecation period is needed so the second patch > could be omitted. I leave that decision to the maintainers. > > v2: Rename the option from memaccess to invalid_mem as suggested by > Peter Maydell Ping? Regards, BALATON Zoltan > BALATON Zoltan (2): > log: Add separate debug option for logging invalid memory accesses > log: Suggest using -d guest_error,invalid_mem instead of guest_errors > > docs/devel/secure-coding-practices.rst | 2 +- > include/qemu/log.h | 1 + > system/memory.c | 6 +++--- > system/physmem.c | 2 +- > tests/avocado/smmu.py | 2 +- > tests/qtest/pnv-host-i2c-test.c | 2 +- > util/log.c | 8 +++++++- > 7 files changed, 15 insertions(+), 8 deletions(-) > >