Re: [PATCH v3 1/2] igb: RX descriptors handling cleanup

[Akihiko Odaki <akihiko.odaki@daynix.com>]

On 2023/04/28 21:51, Tomasz Dzieciol/VIM Integration (NC) 
/SRPOL/Engineer/Samsung Electronics wrote:
>> Please don't ignore comments in reviews, and if you have a question with them or you don't agree with them, please write so in a reply. You don't have to post a new version quickly so take time to address all problems pointed out.
> 
> I assumed that comments referred only to places pointed in the code and fixed only those places. Sorry about that. I will keep in mind that your comments are more general and fix all the places, where array is passed as parameter.
> 
>> Please split up those changes into separate patches.
> 
> I will extract TCP ACK detection removal and IPv6 extensions traffic detection to separate patches. Those will be small patches in comparison to the rest of cleanup, however those are functional changes.
> 
>> Do *not*:
>> - suffix struct name with _st. The convention is not common in QEMU code base, or even e1000e and igb do not always use the suffixes.
>> - use _.
> 
> ok, I was looking at E1000E_RingInfo_st, which was added recently with IGB code in commit 3a977deebe6b9a10043182e922f6883924ef21f5 ("Intrdocue igb device emulation").

It's just copied from e1000e code. Check for e1000e_core.c for history 
older than that commit.