qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] hexagon: use env keyword argument to pass PYTHONPATH
Date: Thu, 11 Mar 2021 07:14:29 -0600	[thread overview]
Message-ID: <a904d698-05fc-1efa-652a-c8a43a81f7fc@linaro.org> (raw)
In-Reply-To: <20210310104937.253532-5-pbonzini@redhat.com>

On 3/10/21 4:49 AM, Paolo Bonzini wrote:
> This feature is new in meson 0.57 and allows getting rid of the "env" wrapper.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   target/hexagon/meson.build | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
> index bb0b4fb621..aaeee11ac1 100644
> --- a/target/hexagon/meson.build
> +++ b/target/hexagon/meson.build
> @@ -156,7 +156,8 @@ dectree_generated = custom_target(
>       'dectree_generated.h.inc',
>       output: 'dectree_generated.h.inc',
>       depends: [iset_py],
> -    command: ['env', 'PYTHONPATH=' + meson.current_build_dir(), files('dectree.py'), '@OUTPUT@'],
> +    env: {'PYTHONPATH': meson.current_build_dir()},
> +    command: [python, files('dectree.py'), '@OUTPUT@'],
>   )
>   hexagon_ss.add(dectree_generated)
>   
> 

This also fixes the python command nit I mentioned vs patch 1.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


      reply	other threads:[~2021-03-11 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 10:49 [PATCH 0/4] Upgrade Meson to 0.57.x Paolo Bonzini
2021-03-10 10:49 ` [PATCH 1/4] hexagon: do not specify Python scripts as inputs Paolo Bonzini
2021-03-10 10:56   ` Philippe Mathieu-Daudé
2021-03-11 13:11   ` Richard Henderson
2021-03-11 17:47     ` Paolo Bonzini
2021-03-10 10:49 ` [PATCH 2/4] meson: bump submodule to 0.57.1 Paolo Bonzini
2021-03-10 10:49 ` [PATCH 3/4] meson: switch minimum meson version to 0.57.0 Paolo Bonzini
2021-03-10 10:49 ` [PATCH 4/4] hexagon: use env keyword argument to pass PYTHONPATH Paolo Bonzini
2021-03-11 13:14   ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a904d698-05fc-1efa-652a-c8a43a81f7fc@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).