From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBDEC433E6 for ; Tue, 1 Sep 2020 17:52:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87085206FA for ; Tue, 1 Sep 2020 17:52:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ns2hSOe6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87085206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDAS9-0005LB-Jy for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 13:52:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDAQY-0003X3-9T for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:50:38 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:34953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDAQW-0002it-48 for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:50:37 -0400 Received: by mail-pl1-x644.google.com with SMTP id a8so914829plm.2 for ; Tue, 01 Sep 2020 10:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EeXj38jjFxK6UZOgdL9WRahH9NASK0CKMsRKW0XxMvM=; b=ns2hSOe6mpTarOGS6L5Hy1Lfe6TvCPEZFOnvlrr4w9H9H+AsWLXD4Vhxa3ngbg/Qxw N3TemV+8lrjDoYekRTWEZ6s96TvDH3+sgDLwDLlWrbVLZevzY/pDemTrpvDxoXlI2+4E dMmez9xJ4QB8zrWKlOfhqvo8AL/cQvq7pwmy9W4piihFR4fFizG1crQm5QboYaFRGgVP X76tUhFMCai57A79Odx4yiXOoetis15JCC2YmjuvN8I0q3pZ5FOpe7UAikRxGYBMJOPd TmDqUk5NDPuJSfxTkRKHJpCfYMF7Cem2RkYgfPn7sUEQUt/GXY+8w0OvCur2+9+KuMLh M9kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EeXj38jjFxK6UZOgdL9WRahH9NASK0CKMsRKW0XxMvM=; b=A7tgog081Xtm1o5wH+e86ZQzRO3a5dddWm4KEg9UWyeP0rRb36M/NSjOp6yVbfRI9V z0Hdtn5FxWtU3b41Tq4Njrw59D+RD3O4pbtdiQLEUJ4kmd7jxoA/BQuYQVFJ5r0ZjfdI fsgjC4jttmXLgSKLqsrfJSTjPhuBKLZdy79qrGGk9tGX3e6mcTqYFiiQk2bxlzsFkGbu JlFzA8PrShkNBZ+1M7+kjH+fBLG9csRixo69XxrhbXrB6a79le8blOS2tkfRK0WD51TN ZTEQM8LtloTQs8RXTeZZOAmT1TeNaiQUzrFuK0rxqwXdss7x8PZyWMFrQjsEcrvBaZ6c 5a0A== X-Gm-Message-State: AOAM533xh3RwmJnmN0URiKWuJB2mhZKVE34mYIlVSW+nIYfEp4XIMGzP WmyTHj9tUhKkTtlGjq7XsC3h3g== X-Google-Smtp-Source: ABdhPJzWKBLaLj/zX/mVPp2lYdZHofGyOFD6M51NLU3sEroBklZfnrxpWV7bvVnTh+NlRr2EkP7OFw== X-Received: by 2002:a17:90a:2e0f:: with SMTP id q15mr2654601pjd.49.1598982634629; Tue, 01 Sep 2020 10:50:34 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id q190sm2602142pfc.176.2020.09.01.10.50.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 10:50:33 -0700 (PDT) Subject: Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200901104043.91383-1-f4bug@amsat.org> <20200901104043.91383-5-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Tue, 1 Sep 2020 10:50:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901104043.91383-5-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , qemu-trivial@nongnu.org, Aleksandar Markovic , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Huacai Chen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aurelien Jarno , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote: > We call pci_register_root_bus() to register 4 IRQs with the > ppc4xx_pci_set_irq() handler. As it can only be called with > values in the [0-4[ range, replace the pointless warning by > an assert(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ppc/ppc4xx_pci.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Richard Henderson r~