Re: [PATCH v2] tests/stream-under-throttle: New test

[Christian Borntraeger <borntraeger@linux.ibm.com>]

Am 14.11.22 um 10:52 schrieb Hanna Reitz:
> Test streaming a base image into the top image underneath two throttle
> nodes.  This was reported to make qemu 7.1 hang
> (https://gitlab.com/qemu-project/qemu/-/issues/1215), so this serves as
> a regression test.
> 
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
> Based-on: <20221107151321.211175-1-hreitz@redhat.com>
> 
> v1: https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00368.html
> 
> v2:
> - Replace `asyncio.exceptions.TimeoutError` by `asyncio.TimeoutError`:
>    Stefan reported that the CI does not recognize the former:
>    https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00424.html
> 
>    As far as I understand, the latter was basically moved to become the
>    former in Python 3.11, and an alias remains, so both are basically
>    equivalent.  I only have 3.10, though, where the documentation says
>    that both are different, even though using either seems to work fine
>    (i.e. both catch the timeout there).  Not sure about previous
>    versions, but the CI seems pretty certain about not knowing
>    `asyncio.exceptions.TimeoutError`, so use `asyncio.TimeoutError`
>    instead.  (Even though that is deprecated in 3.11, but this is not the
>    first place in the tree to use it, so it should not be too bad.)
> ---
>   .../qemu-iotests/tests/stream-under-throttle  | 121 ++++++++++++++++++
>   .../tests/stream-under-throttle.out           |   5 +
>   2 files changed, 126 insertions(+)
>   create mode 100755 tests/qemu-iotests/tests/stream-under-throttle
>   create mode 100644 tests/qemu-iotests/tests/stream-under-throttle.out

As a heads up, I do get the following on s390. I have not yet looked into that:

+EE
+======================================================================
+ERROR: test_stream (__main__.TestStreamWithThrottle)
+Do a simple stream beneath the two throttle nodes.  Should complete
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "qemu/tests/qemu-iotests/tests/stream-under-throttle", line 110, in test_stream
+    self.vm.run_job('stream')
+  File "qemu/tests/qemu-iotests/iotests.py", line 986, in run_job
+    result = self.qmp('query-jobs')
+  File "qemu/python/qemu/machine/machine.py", line 646, in qmp
+    ret = self._qmp.cmd(cmd, args=qmp_args)
+  File "qemu/python/qemu/qmp/legacy.py", line 204, in cmd
+    return self.cmd_obj(qmp_cmd)
+  File "qemu/python/qemu/qmp/legacy.py", line 184, in cmd_obj
+    self._qmp._raw(qmp_cmd, assign_id=False),
+  File "qemu/python/qemu/qmp/protocol.py", line 154, in _wrapper
+    raise StateError(emsg, proto.runstate, required_state)
+qemu.qmp.protocol.StateError: QMPClient is disconnecting. Call disconnect() to return to IDLE state.
+
+======================================================================
+ERROR: test_stream (__main__.TestStreamWithThrottle)
+Do a simple stream beneath the two throttle nodes.  Should complete
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "qemu/python/qemu/machine/machine.py", line 533, in _soft_shutdown
+    self.qmp('quit')
+  File "qemu/python/qemu/machine/machine.py", line 646, in qmp
+    ret = self._qmp.cmd(cmd, args=qmp_args)
+  File "qemu/python/qemu/qmp/legacy.py", line 204, in cmd
+    return self.cmd_obj(qmp_cmd)
+  File "qemu/python/qemu/qmp/legacy.py", line 184, in cmd_obj
+    self._qmp._raw(qmp_cmd, assign_id=False),
+  File "qemu/python/qemu/qmp/protocol.py", line 154, in _wrapper
+    raise StateError(emsg, proto.runstate, required_state)
+qemu.qmp.protocol.StateError: QMPClient is disconnecting. Call disconnect() to return to IDLE state.
+
+During handling of the above exception, another exception occurred:
+
+Traceback (most recent call last):
+  File "qemu/python/qemu/machine/machine.py", line 554, in _do_shutdown
+    self._soft_shutdown(timeout)
+  File "qemu/python/qemu/machine/machine.py", line 536, in _soft_shutdown
+    self._close_qmp_connection()
+  File "qemu/python/qemu/machine/machine.py", line 476, in _close_qmp_connection
+    self._qmp.close()
+  File "qemu/python/qemu/qmp/legacy.py", line 277, in close
+    self._sync(
+  File "qemu/python/qemu/qmp/legacy.py", line 94, in _sync
+    return self._aloop.run_until_complete(
+  File "/usr/lib64/python3.10/asyncio/base_events.py", line 649, in run_until_complete
+    return future.result()
+  File "/usr/lib64/python3.10/asyncio/tasks.py", line 408, in wait_for
+    return await fut
+  File "qemu/python/qemu/qmp/protocol.py", line 398, in disconnect
+    await self._wait_disconnect()
+  File "qemu/python/qemu/qmp/protocol.py", line 710, in _wait_disconnect
+    await all_defined_tasks  # Raise Exceptions from the bottom half.
+  File "qemu/python/qemu/qmp/protocol.py", line 861, in _bh_loop_forever
+    await async_fn()
+  File "qemu/python/qemu/qmp/protocol.py", line 899, in _bh_recv_message
+    msg = await self._recv()
+  File "qemu/python/qemu/qmp/protocol.py", line 1000, in _recv
+    message = await self._do_recv()
+  File "qemu/python/qemu/qmp/qmp_client.py", line 402, in _do_recv
+    msg_bytes = await self._readline()
+  File "qemu/python/qemu/qmp/protocol.py", line 968, in _readline
+    raise EOFError
+EOFError
+
+The above exception was the direct cause of the following exception:
+
+Traceback (most recent call last):
+  File "qemu/tests/qemu-iotests/tests/stream-under-throttle", line 94, in tearDown
+    self.vm.shutdown()
+  File "qemu/python/qemu/machine/machine.py", line 583, in shutdown
+    self._do_shutdown(timeout)
+  File "qemu/python/qemu/machine/machine.py", line 557, in _do_shutdown
+    raise AbnormalShutdown("Could not perform graceful shutdown") \
+qemu.machine.machine.AbnormalShutdown: Could not perform graceful shutdown
+
  ----------------------------------------------------------------------
  Ran 1 tests