qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-block@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript
Date: Wed, 23 Oct 2019 11:41:41 -0400	[thread overview]
Message-ID: <a91f4a69-c219-cf82-bd2a-f368cf4778f0@redhat.com> (raw)
In-Reply-To: <20191021214117.18091-1-ehabkost@redhat.com>



On 10/21/19 5:41 PM, Eduardo Habkost wrote:
> OSError can't be used like a tuple on Python 3, so change the
> code to use `e.sterror` instead of `e[1]`.
> 
> Reported-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: John Snow <jsnow@redhat.com>

> ---
>  tests/image-fuzzer/runner.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
> index 95d84f38f3..1eb2138f94 100755
> --- a/tests/image-fuzzer/runner.py
> +++ b/tests/image-fuzzer/runner.py
> @@ -159,7 +159,7 @@ class TestEnv(object):
>              os.makedirs(self.current_dir)
>          except OSError as e:
>              print("Error: The working directory '%s' cannot be used. Reason: %s"\
> -                % (self.work_dir, e[1]), file=sys.stderr)
> +                % (self.work_dir, e.strerror), file=sys.stderr)
>              raise TestException
>          self.log = open(os.path.join(self.current_dir, "test.log"), "w")
>          self.parent_log = open(run_log, "a")
> @@ -246,7 +246,7 @@ class TestEnv(object):
>              except OSError as e:
>                  multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
>                           % (test_summary, os.path.basename(current_cmd[0]),
> -                            e[1]),
> +                            e.strerror),
>                           sys.stderr, self.log, self.parent_log)
>                  raise TestException
>  
> 

-- 
—js



  reply	other threads:[~2019-10-23 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 21:41 [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript Eduardo Habkost
2019-10-23 15:41 ` John Snow [this message]
2019-11-05 15:36 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a91f4a69-c219-cf82-bd2a-f368cf4778f0@redhat.com \
    --to=jsnow@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).