qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: alistair.francis@wdc.com, qemu-riscv@nongnu.org, zhiwei_liu@c-sky.com
Subject: Re: [PATCH v4 15/16] target/riscv: Use riscv_csrrw_debug for cpu_dump
Date: Mon, 18 Oct 2021 19:55:52 -0700	[thread overview]
Message-ID: <a92f732b-1ef2-1a53-c6d1-6ecf67f3ce28@linaro.org> (raw)
In-Reply-To: <20211019000108.3678724-16-richard.henderson@linaro.org>

On 10/18/21 5:01 PM, Richard Henderson wrote:
> +            result = riscv_csrrw_debug(env, dump_csrs[i].csrno, &val, 0, 0);
> +            assert(result == RISCV_EXCP_NONE);
> +            qemu_fprintf(f, " %-8s " TARGET_FMT_lx "\n",
> +                         dump_csrs[i].name, val);

Ho hum, this assert fires under testing.
I'll have another look tomorrow.

r~


  reply	other threads:[~2021-10-19  2:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  0:00 [PATCH v4 00/16] target/riscv: Rationalize XLEN and operand length Richard Henderson
2021-10-19  0:00 ` [PATCH v4 01/16] target/riscv: Move cpu_get_tb_cpu_state out of line Richard Henderson
2021-10-19  0:00 ` [PATCH v4 02/16] target/riscv: Create RISCVMXL enumeration Richard Henderson
2021-10-19  0:00 ` [PATCH v4 03/16] target/riscv: Split misa.mxl and misa.ext Richard Henderson
2021-10-19  0:00 ` [PATCH v4 04/16] target/riscv: Replace riscv_cpu_is_32bit with riscv_cpu_mxl Richard Henderson
2021-10-19  0:00 ` [PATCH v4 05/16] target/riscv: Add MXL/SXL/UXL to TB_FLAGS Richard Henderson
2021-10-19  0:00 ` [PATCH v4 06/16] target/riscv: Use REQUIRE_64BIT in amo_check64 Richard Henderson
2021-10-19  0:00 ` [PATCH v4 07/16] target/riscv: Properly check SEW in amo_op Richard Henderson
2021-10-19  0:01 ` [PATCH v4 08/16] target/riscv: Replace is_32bit with get_xl/get_xlen Richard Henderson
2021-10-19  0:01 ` [PATCH v4 09/16] target/riscv: Replace DisasContext.w with DisasContext.ol Richard Henderson
2021-10-19  2:24   ` LIU Zhiwei
2021-10-19  2:30     ` Richard Henderson
2021-10-19  0:01 ` [PATCH v4 10/16] target/riscv: Use gen_arith_per_ol for RVM Richard Henderson
2021-10-19  0:01 ` [PATCH v4 11/16] target/riscv: Adjust trans_rev8_32 for riscv64 Richard Henderson
2021-10-19  0:01 ` [PATCH v4 12/16] target/riscv: Use gen_unary_per_ol for RVB Richard Henderson
2021-10-19  0:01 ` [PATCH v4 13/16] target/riscv: Use gen_shift*_per_ol for RVB, RVI Richard Henderson
2021-10-19  0:01 ` [PATCH v4 14/16] target/riscv: Align gprs and fprs in cpu_dump Richard Henderson
2021-10-19  2:42   ` LIU Zhiwei
2021-10-19  0:01 ` [PATCH v4 15/16] target/riscv: Use riscv_csrrw_debug for cpu_dump Richard Henderson
2021-10-19  2:55   ` Richard Henderson [this message]
2021-10-19  0:01 ` [PATCH v4 16/16] target/riscv: Compute mstatus.sd on demand Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a92f732b-1ef2-1a53-c6d1-6ecf67f3ce28@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=zhiwei_liu@c-sky.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).