From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B964C433F5 for ; Tue, 19 Oct 2021 02:56:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C261611BF for ; Tue, 19 Oct 2021 02:56:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C261611BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:35814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcfJB-0003GF-Hp for qemu-devel@archiver.kernel.org; Mon, 18 Oct 2021 22:56:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcfID-0002Qu-TI for qemu-devel@nongnu.org; Mon, 18 Oct 2021 22:55:57 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:42987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcfIC-0005NY-AO for qemu-devel@nongnu.org; Mon, 18 Oct 2021 22:55:57 -0400 Received: by mail-pf1-x42d.google.com with SMTP id m14so16324969pfc.9 for ; Mon, 18 Oct 2021 19:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MKKSP9NC6BdMlcCy5Vpq+LZEIVHvncHsl4RqK0w/DTU=; b=Eex06PrjAiDlHSf/ezM1N9pGHgkpA1SnxMPLUx6cTb8Yydkqb9woniTFP7KeEL24Cy IGZtw0cMhyp/AuWM4HiHEVpsJq9x6OzLz4RQYBtb9NHFwCTFXcy0g52pk2zL47jbK7U5 25Szb//Y9mQWVmf6gIhj0sRNoUTzaXJszZVGvKwUf/bxAVTRq6EaFsSu9bFdqnoOg/Gr yIFyKGI/JfBPtYZUt9IEGWqGzY9qw3ATPhfHlHFcogNIjAhmT7krT/gKYmHawE2EHDz7 /qipgqBXkPjKHG3HTEqRE+XD2aIOatDw9clST/AroE6z5TrMV24tyhJxKKPPs1noKg1h 08nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MKKSP9NC6BdMlcCy5Vpq+LZEIVHvncHsl4RqK0w/DTU=; b=JhNxOAvO9fKukWbbvmdRdG0CwmkLdGZPQ6cFGRRyA3yw7GNd4PtbJQw2j+Mu9oOZGs WT22dwafQjg1wP6xoLJ0ncDfLmE9a5E050hag7Rm5a9xfHhekjiAdaHyo0wzlYm9YueB g3hOuCyxVzkw0CKhBksEaOxZojGft6+Xiwa2rPuRBgI8UAFOz8GVHd8+ctnWrrwiNa6o 7dyyzfqycNFhVs7lahu/LstPYYxwLkEtmXwDVMlK/Uak1CXU3eR61asZQB419chvqoHL CP9QiFbUd3BMFVxtGi0EyutFN/xAlilcOqfLO4Tm7nqcKaXLI+oyfH7nuLOpi8c4dXSq Efng== X-Gm-Message-State: AOAM530dX/sZVZcNdBhnwptH6R26OhNkjas8rBGPQcLH5GRCwxUXEY/o XDakLyFSK7OJB+eX+xGcY5hr9w== X-Google-Smtp-Source: ABdhPJwwAevXlCIKFZCIAZjBN41A8nEOc3977yWAkCxDmrMtvbZpdUkWP6sUbktA5IFbanRZbCqypQ== X-Received: by 2002:a05:6a00:1407:b0:44c:d2cc:916e with SMTP id l7-20020a056a00140700b0044cd2cc916emr32700364pfu.64.1634612154545; Mon, 18 Oct 2021 19:55:54 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id j126sm14795431pfd.113.2021.10.18.19.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 19:55:54 -0700 (PDT) Subject: Re: [PATCH v4 15/16] target/riscv: Use riscv_csrrw_debug for cpu_dump From: Richard Henderson To: qemu-devel@nongnu.org References: <20211019000108.3678724-1-richard.henderson@linaro.org> <20211019000108.3678724-16-richard.henderson@linaro.org> Message-ID: Date: Mon, 18 Oct 2021 19:55:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211019000108.3678724-16-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair.francis@wdc.com, qemu-riscv@nongnu.org, zhiwei_liu@c-sky.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/18/21 5:01 PM, Richard Henderson wrote: > + result = riscv_csrrw_debug(env, dump_csrs[i].csrno, &val, 0, 0); > + assert(result == RISCV_EXCP_NONE); > + qemu_fprintf(f, " %-8s " TARGET_FMT_lx "\n", > + dump_csrs[i].name, val); Ho hum, this assert fires under testing. I'll have another look tomorrow. r~