From: BALATON Zoltan via <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@kernel.org>, f4bug@amsat.org
Subject: [PATCH 18/24] vt82c686: Simplify vt82c686b_realize()
Date: Sat, 02 Jan 2021 11:43:35 +0100 [thread overview]
Message-ID: <a9312553c9bf4e9992fd6aa8f21a33c68d5e406c.1609584216.git.balaton@eik.bme.hu> (raw)
In-Reply-To: <cover.1609584215.git.balaton@eik.bme.hu>
Remove unneeded variables and setting value to 0 on zero initialised
data and replace check for error with error_fatal. Rationalise loop
that sets PCI config header fields read only.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/isa/vt82c686.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index a989e29fe5..ead60310fe 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -363,24 +363,16 @@ static void vt82c686b_isa_reset(DeviceState *dev)
static void vt82c686b_realize(PCIDevice *d, Error **errp)
{
VT82C686BISAState *s = VT82C686B_ISA(d);
- uint8_t *pci_conf;
+ DeviceState *dev = DEVICE(d);
ISABus *isa_bus;
- uint8_t *wmask;
int i;
- isa_bus = isa_bus_new(DEVICE(d), get_system_memory(),
- pci_address_space_io(d), errp);
- if (!isa_bus) {
- return;
- }
-
- pci_conf = d->config;
- pci_config_set_prog_interface(pci_conf, 0x0);
+ isa_bus = isa_bus_new(dev, get_system_memory(), pci_address_space_io(d),
+ &error_fatal);
- wmask = d->wmask;
- for (i = 0x00; i < 0xff; i++) {
- if (i <= 0x03 || (i >= 0x08 && i <= 0x3f)) {
- wmask[i] = 0x00;
+ for (i = 0; i < PCI_CONFIG_HEADER_SIZE; i++) {
+ if (i < PCI_COMMAND || i >= PCI_REVISION_ID) {
+ d->wmask[i] = 0;
}
}
--
2.21.3
next prev parent reply other threads:[~2021-01-02 11:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 10:43 [PATCH 00/24] vt82c686b clean ups and vt8231 emulation - all in one BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 14/24] vt82c686: Reorganise code BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 19/24] vt82c686: Move creation of ISA devices to the ISA bridge BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 20/24] vt82c686: Fix superio_cfg_{read,write}() functions BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 02/24] vt82c686: Remove unnecessary _DEVICE suffix from type macros BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 24/24] vt82c686: Add emulation of VT8231 south bridge BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 22/24] vt82c686: QOM-ify superio related functionality BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 04/24] vt82c686: Remove vt82c686b_[am]c97_init() functions BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 15/24] vt82c686: Fix SMBus IO base and configuration registers BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 05/24] vt82c686: Split off via-[am]c97 into separate file in hw/audio BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 06/24] audio/via-ac97: Simplify code and set user_creatable to false BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 01/24] vt82c686: Rename AC97/MC97 parts from VT82C686B to VIA BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 08/24] vt82c686: Remove legacy vt82c686b_pm_init() function BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 23/24] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 17/24] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 11/24] vt82c686: Use shorter name for local variable holding object state BALATON Zoltan via
2021-01-03 12:16 ` Philippe Mathieu-Daudé
2021-01-02 10:43 ` BALATON Zoltan via [this message]
2021-01-02 10:43 ` [PATCH 09/24] vt82c686: Convert debug printf to trace points BALATON Zoltan via
2021-01-03 12:17 ` Philippe Mathieu-Daudé
2021-01-02 10:43 ` [PATCH 07/24] vt82c686: Remove legacy vt82c686b_isa_init() function BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 10/24] vt82c686: Remove unneeded includes and defines BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 13/24] vt82c686: Move superio memory region to SuperIOConfig struct BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 12/24] vt82c686: Rename superio config related parts BALATON Zoltan via
2021-01-03 12:16 ` Philippe Mathieu-Daudé
2021-01-02 10:43 ` [PATCH 16/24] vt82c686: Fix up power management io base and config BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 03/24] vt82c686b: Rename VT82C686B to VT82C686B_ISA BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 21/24] vt82c686: Implement control of serial port io ranges via config regs BALATON Zoltan via
2021-01-03 13:55 ` [PATCH 00/24] vt82c686b clean ups and vt8231 emulation - all in one Philippe Mathieu-Daudé
2021-01-03 14:27 ` BALATON Zoltan via
2021-01-03 15:45 ` Philippe Mathieu-Daudé
2021-01-03 17:07 ` BALATON Zoltan via
2021-01-04 6:38 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9312553c9bf4e9992fd6aa8f21a33c68d5e406c.1609584216.git.balaton@eik.bme.hu \
--to=qemu-devel@nongnu.org \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).