From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Hildenbrand" <david@redhat.com>
Cc: Frank Chang <frank.chang@sifive.com>,
LIU Zhiwei <zhiwei_liu@c-sky.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] tcg: Use memset for large vector byte replication
Date: Wed, 16 Dec 2020 08:28:59 -0600 [thread overview]
Message-ID: <a9383ed6-c6fd-801e-a80a-b3bc5798021d@linaro.org> (raw)
In-Reply-To: <c95edce5-98fb-a1c5-116b-f1736b389fd4@amsat.org>
On 12/15/20 5:38 PM, Philippe Mathieu-Daudé wrote:
> BTW (nitpicking) I'd rewrite the epilogue as:
>
> if (!in_32) {
> tcg_temp_free_i32(t_val);
> }
> tcg_temp_free_ptr(t_size);
>
> tcg_temp_free_ptr(t_ptr);
> return;
>
> t_val first, because the !in_32 allocs are few lines earlier,
> t_ptr last because allocated in prologue, so keep close to
> 'return'. Matter of taste ;)
Yah sure, you bettcha. Queued with this.
r~
prev parent reply other threads:[~2020-12-16 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 17:48 [PATCH] tcg: Use memset for large vector byte replication Richard Henderson
2020-12-15 23:38 ` Philippe Mathieu-Daudé
2020-12-16 14:28 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9383ed6-c6fd-801e-a80a-b3bc5798021d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=frank.chang@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=zhiwei_liu@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).