From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] x86: ioapic: fix fail migrate when irqchip=split
Date: Mon, 9 Jan 2017 10:04:06 +0100 [thread overview]
Message-ID: <a93b912d-7b2c-39f9-6335-3335fef3191f@redhat.com> (raw)
In-Reply-To: <1483952153-7221-1-git-send-email-peterx@redhat.com>
On 09/01/2017 09:55, Peter Xu wrote:
> Split irqchip works based on the fact that we kept the first 24 gsi
> routing entries inside KVM for userspace ioapic's use. When system
> boot, we'll reserve these MSI routing entries before hand. However,
> after migration, we forgot to re-configure it up in the destination
> side. The result is, we'll get invalid gsi routing entries after
> migration (all empty), and we get interrupts with vector=0, then
> strange things happen, like keyboard hang.
>
> The solution is simple - we update them after migration, which is a
> one line fix in patch 3.
>
> The first two patches are things I used for debugging this issue.
> Though it might not be directly related, I still think it's something
> good to have in case we encounter similar interrupt issues in the
> future.
>
> Please review, thanks,
>
> Peter Xu (3):
> x86: ioapic: add traces for ioapic
> x86: ioapic: dump version for "info ioapic"
> x86: ioapic: fix fail migration when irqchip=split
>
> hw/intc/ioapic.c | 22 ++++++++++++++++++++--
> hw/intc/ioapic_common.c | 3 ++-
> hw/intc/trace-events | 7 +++++++
> 3 files changed, 29 insertions(+), 3 deletions(-)
>
Thanks, queued.
Paolo
prev parent reply other threads:[~2017-01-09 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 8:55 [Qemu-devel] [PATCH 0/3] x86: ioapic: fix fail migrate when irqchip=split Peter Xu
2017-01-09 8:55 ` [Qemu-devel] [PATCH 1/3] x86: ioapic: add traces for ioapic Peter Xu
2017-01-09 8:55 ` [Qemu-devel] [PATCH 2/3] x86: ioapic: dump version for "info ioapic" Peter Xu
2017-01-09 8:55 ` [Qemu-devel] [PATCH 3/3] x86: ioapic: fix fail migration when irqchip=split Peter Xu
2017-01-09 9:04 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a93b912d-7b2c-39f9-6335-3335fef3191f@redhat.com \
--to=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).