qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Eric Blake <eblake@redhat.com>,
	qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	Fiona Ebner <f.ebner@proxmox.com>,
	qemu-trivial@nongnu.org
Subject: Re: [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage()
Date: Mon, 8 Dec 2025 12:10:04 +0100	[thread overview]
Message-ID: <a961c501-d6e6-4567-8e35-9ddaf6356dcd@vivier.eu> (raw)
In-Reply-To: <20251208075320.35682-1-thuth@redhat.com>

On Mon,  8 Dec 2025 08:53:20 +0100 Thomas Huth <thuth@redhat.com> wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Looks like the "$" has been forgotten here to get the contents of
> the FILENAME variable.
>
> Fixes: c49dda7254d ("iotests: Filter out ZFS in several tests")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qemu-iotests/common.rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 10d83d8361b..c0f8f0f8dfa 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -1008,7 +1008,7 @@ _require_disk_usage()
>      else
>          FILENAME="$TEST_IMG_FILE"
>      fi
> -    if [ -e "FILENAME" ]; then
> +    if [ -e "$FILENAME" ]; then
>          echo "unwilling to overwrite existing file"
>          exit 1
>      fi
> -- 
> 2.52.0

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Thanks!


  reply	other threads:[~2025-12-08 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  7:53 [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage() Thomas Huth
2025-12-08 11:10 ` Laurent Vivier [this message]
2025-12-09  7:11 ` Philippe Mathieu-Daudé
2025-12-09 10:48 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a961c501-d6e6-4567-8e35-9ddaf6356dcd@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=eblake@redhat.com \
    --cc=f.ebner@proxmox.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).