From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets
Date: Mon, 14 Mar 2022 09:30:44 +0100 [thread overview]
Message-ID: <a97d0416-111a-4b03-c787-b51facea4a3c@de.ibm.com> (raw)
In-Reply-To: <46cd7fbe-c96e-71b5-a648-da0fce0d2f8d@linaro.org>
Am 11.03.22 um 21:32 schrieb Richard Henderson:
> On 3/11/22 10:49, Ilya Leoshkevich wrote:
>> + size_t length = 0x100000006;
>> + unsigned char *buf;
>> + int i;
>> +
>> + buf = mmap(NULL, length, PROT_READ | PROT_WRITE | PROT_EXEC,
>> + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
>> + assert(buf != MAP_FAILED);
>
> I'm thinking exit success here, as such a large allocation may well fail depending on the host.
What about using MAP_NORESERVE ?
next prev parent reply other threads:[~2022-03-14 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 18:49 [PATCH 0/3] Fix BRASL and BRCL with large negative offsets Ilya Leoshkevich
2022-03-11 18:49 ` [PATCH 1/3] s390x/tcg: Fix BRASL with a large negative offset Ilya Leoshkevich
2022-03-11 18:55 ` David Hildenbrand
2022-03-11 18:49 ` [PATCH 2/3] s390x/tcg: Fix BRCL " Ilya Leoshkevich
2022-03-11 18:55 ` David Hildenbrand
2022-03-11 18:49 ` [PATCH 3/3] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets Ilya Leoshkevich
2022-03-11 18:57 ` David Hildenbrand
2022-03-11 19:01 ` Ilya Leoshkevich
2022-03-11 20:32 ` Richard Henderson
2022-03-14 8:30 ` Christian Borntraeger [this message]
2022-03-14 10:17 ` David Hildenbrand
2022-03-14 17:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a97d0416-111a-4b03-c787-b51facea4a3c@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).