qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/7] tcg/tcg-op: Document bswap64() byte pattern
Date: Tue, 22 Aug 2023 09:00:43 -0700	[thread overview]
Message-ID: <a9889a85-567c-77ef-7193-3bbfd5c1fbf8@linaro.org> (raw)
In-Reply-To: <20230822093712.38922-4-philmd@linaro.org>

On 8/22/23 02:37, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tcg/tcg-op.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> index e6b0d74a46..f4fe13e040 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -1828,6 +1828,11 @@ void tcg_gen_bswap32_i64(TCGv_i64 ret, TCGv_i64 arg, int flags)
>       }
>   }
>   
> +/*
> + * bswap64_i64: 64-bit byte swap on a 64-bit value.
> + *
> + * Byte pattern:  bswap64_i64(abcdefgh) -> hgfedcba
> + */
>   void tcg_gen_bswap64_i64(TCGv_i64 ret, TCGv_i64 arg)
>   {
>       if (TCG_TARGET_REG_BITS == 32) {

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2023-08-22 16:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  9:37 [PATCH 0/7] tcg: Document *swap/deposit helpers Philippe Mathieu-Daudé
2023-08-22  9:37 ` [PATCH 1/7] tcg/tcg-op: Document bswap16() byte pattern Philippe Mathieu-Daudé
2023-08-22 15:58   ` Richard Henderson
2023-08-22 17:22     ` Philippe Mathieu-Daudé
2023-08-22 17:29       ` Richard Henderson
2023-08-22 22:04         ` Philippe Mathieu-Daudé
2023-08-22  9:37 ` [PATCH 2/7] tcg/tcg-op: Document bswap32() " Philippe Mathieu-Daudé
2023-08-22 16:00   ` Richard Henderson
2023-08-23 13:14     ` Philippe Mathieu-Daudé
2023-08-23 15:54       ` Richard Henderson
2023-08-22  9:37 ` [PATCH 3/7] tcg/tcg-op: Document bswap64() " Philippe Mathieu-Daudé
2023-08-22 16:00   ` Richard Henderson [this message]
2023-08-22  9:37 ` [PATCH 4/7] tcg/tcg-op: Document hswap() " Philippe Mathieu-Daudé
2023-08-22 16:02   ` Richard Henderson
2023-08-22 16:04   ` Richard Henderson
2023-08-22  9:37 ` [PATCH 5/7] tcg/tcg-op: Document wswap() " Philippe Mathieu-Daudé
2023-08-22 16:03   ` Richard Henderson
2023-08-22  9:37 ` [PATCH 6/7] tcg/tcg-op: Document deposit_z() Philippe Mathieu-Daudé
2023-08-22 16:05   ` Richard Henderson
2023-08-22  9:37 ` [PATCH 7/7] target/cris: Fix a typo in gen_swapr() Philippe Mathieu-Daudé
2023-08-22 13:42 ` [PATCH 0/7] tcg: Document *swap/deposit helpers Alex Bennée
2023-08-22 13:58   ` Peter Maydell
2023-08-22 14:43   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9889a85-567c-77ef-7193-3bbfd5c1fbf8@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).