qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ninad Palsule <ninad@linux.vnet.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Ninad Palsule" <ninad@linux.ibm.com>,
	qemu-devel@nongnu.org
Cc: joel@jms.id.au, andrew@aj.id.au, stefanb@linux.ibm.com
Subject: Re: [PATCH 1/3] docs: Add support for TPM devices over I2C bus
Date: Fri, 24 Mar 2023 07:50:01 -0500	[thread overview]
Message-ID: <a98f7b1f-dd0d-d20c-a3e7-8dca6882a653@linux.vnet.ibm.com> (raw)
In-Reply-To: <be542d13-ed97-39f6-7386-b83941563216@kaod.org>


On 3/24/23 3:01 AM, Cédric Le Goater wrote:
> On 3/24/23 06:11, Ninad Palsule wrote:
>> Hello Cedric,
>>
>> Joel helped me to configure the device and we are able to configure 
>> tpm device on ast2600-evb.
>>
>> I will include this example in the documentation.
>>
>> # uname -a
>> Linux ast2600-evb 6.1.15 #1 SMP Thu Mar 23 20:48:29 CDT 2023 armv7l 
>> GNU/Linux
>> # cat /etc/os-release
>> NAME=Buildroot
>> VERSION=2023.02-dirty
>> ID=buildroot
>> VERSION_ID=2023.02
>> PRETTY_NAME="Buildroot 2023.02"
>>
>> # echo tpm_tis_i2c 0x2e > /sys/bus/i2c/devices/i2c-12/new_device
>> [   59.681684] tpm_tis_i2c 12-002e: 2.0 TPM (device-id 0x1, rev-id 1)
>> [   59.703190] tpm tpm0: A TPM error (256) occurred attempting the 
>> self test
>> [   59.705215] tpm tpm0: starting up the TPM manually
>> [   59.892917] i2c i2c-12: new_device: Instantiated device 
>> tpm_tis_i2c at 0x2e
>> # cd /sys/class/tpm/tpm0
>> # ls
>> dev                pcr-sha256         power              uevent
>> device             pcr-sha384         subsystem
>> pcr-sha1           pcr-sha512         tpm_version_major
>
>
> Nice. Did you need any special support in the kernel ?
>
> I could update this image for avocado tests :
>
> https://github.com/legoater/qemu-aspeed-boot/tree/master/images/ast2600-evb/buildroot-2023.02

Kernel need a TPM i2c driver support. I built it with following head on 
dev-6.1 branch. You also need to run "echo" command I mentioned above to 
instantiate the device. Also start the swtpm as provided in my earlier mail.

$ git rev-parse HEAD
0e94476a8892056a9242bcd75e59e7d2b92ac435

Thanks,

Ninad


>
> Thanks,
>
> C.


  reply	other threads:[~2023-03-24 15:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  3:01 [PATCH 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-23  3:01 ` [PATCH 1/3] docs: " Ninad Palsule
2023-03-23  7:49   ` Cédric Le Goater
2023-03-23 22:11     ` Ninad Palsule
2023-03-24  3:23     ` Ninad Palsule
2023-03-24  5:11       ` Ninad Palsule
2023-03-24  8:01         ` Cédric Le Goater
2023-03-24 12:50           ` Ninad Palsule [this message]
2023-03-23  3:01 ` [PATCH 2/3] TPM TIS: " Ninad Palsule
2023-03-23  7:44   ` Cédric Le Goater
2023-03-23 15:35     ` Ninad Palsule
2023-03-23  3:01 ` [PATCH 3/3] New I2C: " Ninad Palsule
2023-03-23  8:37   ` Cédric Le Goater
2023-03-23 22:32     ` Ninad Palsule
2023-03-24  8:06       ` Cédric Le Goater
2023-03-23 12:18   ` Stefan Berger
2023-03-23 20:07     ` Ninad Palsule
2023-03-23  7:23 ` [PATCH 0/3] " Cédric Le Goater
2023-03-23 22:35   ` Ninad Palsule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a98f7b1f-dd0d-d20c-a3e7-8dca6882a653@linux.vnet.ibm.com \
    --to=ninad@linux.vnet.ibm.com \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=ninad@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).