qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Michal Privoznik <mprivozn@redhat.com>,
	qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers
Date: Tue, 16 Aug 2016 18:41:21 +0200	[thread overview]
Message-ID: <a99bf314-172b-12eb-5ed9-a2dcb4f71c28@vivier.eu> (raw)
In-Reply-To: <23806aac6db3baf7e2cdab4c62d6e3468ce6b4dc.1471340849.git.mprivozn@redhat.com>

Le 16/08/2016 à 11:47, Michal Privoznik a écrit :
> In c5dff280 we tried to make us understand netlink messages more.
> So we've added a code that does some translation. However, the
> code assumed linux-headers to be at least version 4.4 of it
> because most of the symbols there (if not all of them) were added
> in just that release. This, however, breaks build on systems with
> older versions of the package.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Are you sure this "#ifdef" are correct while all these symbols are enums
not #define?

Or do I miss something?

Thanks,
Laurent

  parent reply	other threads:[~2016-08-16 16:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16  9:47 [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers Michal Privoznik
2016-08-16 10:04 ` Peter Maydell
2016-08-16 10:31   ` Michal Privoznik
2016-08-16 15:41 ` Peter Maydell
2016-08-16 16:41 ` Laurent Vivier [this message]
2016-08-16 16:51   ` Peter Maydell
2016-08-16 16:57     ` Michal Privoznik
2016-08-16 17:28     ` Laurent Vivier
2016-08-16 17:31       ` Peter Maydell
2016-08-16 17:39         ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a99bf314-172b-12eb-5ed9-a2dcb4f71c28@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=mprivozn@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).