* [PATCH v2 0/2] Update description for input grab key
@ 2024-02-21 19:52 Tianlan Zhou
2024-02-21 19:52 ` [PATCH v2 1/2] docs/system: " Tianlan Zhou
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Tianlan Zhou @ 2024-02-21 19:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, qemu-trivial, Tianlan Zhou
Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
v2:
- Update help message in system/vl.c
v1:
- Initial patch
Tianlan Zhou (2):
docs/system: Update description for input grab key
system/vl: Update description for input grab key
docs/system/keys.rst.inc | 2 +-
system/vl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.38.1.windows.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] docs/system: Update description for input grab key
2024-02-21 19:52 [PATCH v2 0/2] Update description for input grab key Tianlan Zhou
@ 2024-02-21 19:52 ` Tianlan Zhou
2024-02-22 4:03 ` Thomas Huth
2024-02-21 19:52 ` [PATCH v2 2/2] system/vl: " Tianlan Zhou
2024-02-22 6:00 ` [PATCH v2 0/2] " Michael Tokarev
2 siblings, 1 reply; 8+ messages in thread
From: Tianlan Zhou @ 2024-02-21 19:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, qemu-trivial, Tianlan Zhou
Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
Signed-off-by: Tianlan Zhou <bobby825@126.com>
---
docs/system/keys.rst.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
index 2e2c97aa23..59966a3fe7 100644
--- a/docs/system/keys.rst.inc
+++ b/docs/system/keys.rst.inc
@@ -29,7 +29,7 @@ Ctrl-Alt-n
*3*
Serial port
-Ctrl-Alt
+Ctrl-Alt-g
Toggle mouse and keyboard grab.
In the virtual consoles, you can use Ctrl-Up, Ctrl-Down, Ctrl-PageUp and
--
2.38.1.windows.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] system/vl: Update description for input grab key
2024-02-21 19:52 [PATCH v2 0/2] Update description for input grab key Tianlan Zhou
2024-02-21 19:52 ` [PATCH v2 1/2] docs/system: " Tianlan Zhou
@ 2024-02-21 19:52 ` Tianlan Zhou
2024-02-22 4:02 ` Thomas Huth
2024-02-22 12:50 ` Tianlan Zhou
2024-02-22 6:00 ` [PATCH v2 0/2] " Michael Tokarev
2 siblings, 2 replies; 8+ messages in thread
From: Tianlan Zhou @ 2024-02-21 19:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, qemu-trivial, Tianlan Zhou
Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
Signed-off-by: Tianlan Zhou <bobby825@126.com>
---
system/vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/system/vl.c b/system/vl.c
index a82555ae15..b8469d9965 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -891,7 +891,7 @@ static void help(int exitcode)
printf("\nDuring emulation, the following keys are useful:\n"
"ctrl-alt-f toggle full screen\n"
"ctrl-alt-n switch to virtual console 'n'\n"
- "ctrl-alt toggle mouse and keyboard grab\n"
+ "ctrl-alt-g toggle mouse and keyboard grab\n"
"\n"
"When using -nographic, press 'ctrl-a h' to get some help.\n"
"\n"
--
2.38.1.windows.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] system/vl: Update description for input grab key
2024-02-21 19:52 ` [PATCH v2 2/2] system/vl: " Tianlan Zhou
@ 2024-02-22 4:02 ` Thomas Huth
2024-02-22 12:50 ` Tianlan Zhou
1 sibling, 0 replies; 8+ messages in thread
From: Thomas Huth @ 2024-02-22 4:02 UTC (permalink / raw)
To: Tianlan Zhou, qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, qemu-trivial
On 21/02/2024 20.52, Tianlan Zhou wrote:
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
>
> Signed-off-by: Tianlan Zhou <bobby825@126.com>
> ---
> system/vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/vl.c b/system/vl.c
> index a82555ae15..b8469d9965 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -891,7 +891,7 @@ static void help(int exitcode)
> printf("\nDuring emulation, the following keys are useful:\n"
> "ctrl-alt-f toggle full screen\n"
> "ctrl-alt-n switch to virtual console 'n'\n"
> - "ctrl-alt toggle mouse and keyboard grab\n"
> + "ctrl-alt-g toggle mouse and keyboard grab\n"
> "\n"
> "When using -nographic, press 'ctrl-a h' to get some help.\n"
> "\n"
Fixes: f8d2c9369b ("sdl: use ctrl-alt-g as grab hotkey")
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] docs/system: Update description for input grab key
2024-02-21 19:52 ` [PATCH v2 1/2] docs/system: " Tianlan Zhou
@ 2024-02-22 4:03 ` Thomas Huth
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Huth @ 2024-02-22 4:03 UTC (permalink / raw)
To: Tianlan Zhou, qemu-devel
Cc: Alex Bennée, Paolo Bonzini, qemu-trivial, Gerd Hoffmann
On 21/02/2024 20.52, Tianlan Zhou wrote:
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
>
> Signed-off-by: Tianlan Zhou <bobby825@126.com>
> ---
> docs/system/keys.rst.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> index 2e2c97aa23..59966a3fe7 100644
> --- a/docs/system/keys.rst.inc
> +++ b/docs/system/keys.rst.inc
> @@ -29,7 +29,7 @@ Ctrl-Alt-n
> *3*
> Serial port
>
> -Ctrl-Alt
> +Ctrl-Alt-g
> Toggle mouse and keyboard grab.
>
> In the virtual consoles, you can use Ctrl-Up, Ctrl-Down, Ctrl-PageUp and
Fixes: f8d2c9369b ("sdl: use ctrl-alt-g as grab hotkey")
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] Update description for input grab key
2024-02-21 19:52 [PATCH v2 0/2] Update description for input grab key Tianlan Zhou
2024-02-21 19:52 ` [PATCH v2 1/2] docs/system: " Tianlan Zhou
2024-02-21 19:52 ` [PATCH v2 2/2] system/vl: " Tianlan Zhou
@ 2024-02-22 6:00 ` Michael Tokarev
2 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2024-02-22 6:00 UTC (permalink / raw)
To: Tianlan Zhou, qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, qemu-trivial
21.02.2024 22:52, Tianlan Zhou :
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
>
> v2:
> - Update help message in system/vl.c
>
> v1:
> - Initial patch
>
> Tianlan Zhou (2):
> docs/system: Update description for input grab key
> system/vl: Update description for input grab key
>
> docs/system/keys.rst.inc | 2 +-
> system/vl.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to trivial-patches, thanks!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] system/vl: Update description for input grab key
2024-02-21 19:52 ` [PATCH v2 2/2] system/vl: " Tianlan Zhou
2024-02-22 4:02 ` Thomas Huth
@ 2024-02-22 12:50 ` Tianlan Zhou
2024-02-22 15:49 ` Michael Tokarev
1 sibling, 1 reply; 8+ messages in thread
From: Tianlan Zhou @ 2024-02-22 12:50 UTC (permalink / raw)
To: Tianlan Zhou, qemu-devel; +Cc: Michael Tokarev, qemu-trivial, qemu-stable
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
Cc qemu-stable, as this will fix the `qemu-system-xxx -h` help message.
On 2024/2/22 3:52, Tianlan Zhou wrote:
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
>
> Signed-off-by: Tianlan Zhou <bobby825@126.com>
> ---
> system/vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/vl.c b/system/vl.c
> index a82555ae15..b8469d9965 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -891,7 +891,7 @@ static void help(int exitcode)
> printf("\nDuring emulation, the following keys are useful:\n"
> "ctrl-alt-f toggle full screen\n"
> "ctrl-alt-n switch to virtual console 'n'\n"
> - "ctrl-alt toggle mouse and keyboard grab\n"
> + "ctrl-alt-g toggle mouse and keyboard grab\n"
> "\n"
> "When using -nographic, press 'ctrl-a h' to get some help.\n"
> "\n"
> --
> 2.38.1.windows.1
[-- Attachment #2: Type: text/html, Size: 2256 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] system/vl: Update description for input grab key
2024-02-22 12:50 ` Tianlan Zhou
@ 2024-02-22 15:49 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2024-02-22 15:49 UTC (permalink / raw)
To: Tianlan Zhou, qemu-devel; +Cc: qemu-trivial, qemu-stable
22.02.2024 15:50, Tianlan Zhou wrote:
> Cc qemu-stable, as this will fix the `qemu-system-xxx -h` help message.
Yes, I already picked up both of them.
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-02-22 15:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21 19:52 [PATCH v2 0/2] Update description for input grab key Tianlan Zhou
2024-02-21 19:52 ` [PATCH v2 1/2] docs/system: " Tianlan Zhou
2024-02-22 4:03 ` Thomas Huth
2024-02-21 19:52 ` [PATCH v2 2/2] system/vl: " Tianlan Zhou
2024-02-22 4:02 ` Thomas Huth
2024-02-22 12:50 ` Tianlan Zhou
2024-02-22 15:49 ` Michael Tokarev
2024-02-22 6:00 ` [PATCH v2 0/2] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).