From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
John Snow <jsnow@redhat.com>,
Radoslaw Biernacki <rad@semihalf.com>,
Peter Maydell <peter.maydell@linaro.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH 11/20] hw/ide: Rename ide_create_drive() -> ide_bus_create_drive()
Date: Wed, 15 Feb 2023 09:13:08 -1000 [thread overview]
Message-ID: <a9bca328-5c27-0c55-8ccc-a2df40b61ae9@linaro.org> (raw)
In-Reply-To: <20230215112712.23110-12-philmd@linaro.org>
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote:
> ide_create_drive() operates on a IDEBus; rename it as
> ide_bus_create_drive() to emphasize its first argument
> is a IDEBus.
>
> Mechanical change using:
>
> $ sed -i -e 's/ide_create_drive/ide_bus_create_drive/g' \
> $(git grep -wl ide_create_drive)
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> hw/arm/sbsa-ref.c | 2 +-
> hw/ide/ahci.c | 2 +-
> hw/ide/isa.c | 4 ++--
> hw/ide/macio.c | 2 +-
> hw/ide/microdrive.c | 2 +-
> hw/ide/mmio.c | 4 ++--
> hw/ide/pci.c | 2 +-
> hw/ide/qdev.c | 2 +-
> include/hw/ide/internal.h | 2 +-
> 9 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-02-15 19:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 11:26 [PATCH 00/20] hw/ide: QOM/QDev housekeeping Philippe Mathieu-Daudé
2023-02-15 11:26 ` [PATCH 01/20] MAINTAINERS: Mark IDE and Floppy as "Odd Fixes" Philippe Mathieu-Daudé
2023-02-15 17:27 ` Alex Bennée
2023-02-15 20:51 ` Philippe Mathieu-Daudé
2023-02-15 11:26 ` [PATCH 02/20] hw/ide/mmio: Use CamelCase for MMIO_IDE state name Philippe Mathieu-Daudé
2023-02-15 17:29 ` Alex Bennée
2023-02-15 11:26 ` [PATCH 03/20] hw/ide/mmio: Extract TYPE_MMIO_IDE declarations to 'hw/ide/mmio.h' Philippe Mathieu-Daudé
2023-02-15 17:32 ` Alex Bennée
2023-02-15 19:06 ` Richard Henderson
2023-02-15 11:26 ` [PATCH 04/20] hw/ide/isa: Extract TYPE_ISA_IDE declarations to 'hw/ide/isa.h' Philippe Mathieu-Daudé
2023-02-15 19:08 ` Richard Henderson
2023-02-16 14:19 ` Bernhard Beschow
2023-02-15 11:26 ` [PATCH 05/20] hw/ide/isa: Remove intermediate ISAIDEState::irq variable Philippe Mathieu-Daudé
2023-02-15 17:54 ` Bernhard Beschow
2023-02-15 19:08 ` Richard Henderson
2023-02-15 11:26 ` [PATCH 06/20] hw/ide/atapi: Restrict 'scsi/constants.h' inclusion Philippe Mathieu-Daudé
2023-02-15 19:09 ` Richard Henderson
2023-02-15 11:26 ` [PATCH 07/20] hw/ide: Remove unused 'qapi/qapi-types-run-state.h' Philippe Mathieu-Daudé
2023-02-15 19:09 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 08/20] hw/ide: Include 'exec/ioport.h' instead of 'hw/isa/isa.h' Philippe Mathieu-Daudé
2023-02-15 19:09 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 09/20] hw/ide: Un-inline ide_set_irq() Philippe Mathieu-Daudé
2023-02-15 19:11 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 10/20] hw/ide: Rename ide_set_irq() -> ide_bus_set_irq() Philippe Mathieu-Daudé
2023-02-15 19:12 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 11/20] hw/ide: Rename ide_create_drive() -> ide_bus_create_drive() Philippe Mathieu-Daudé
2023-02-15 19:13 ` Richard Henderson [this message]
2023-02-15 11:27 ` [PATCH 12/20] hw/ide: Rename ide_register_restart_cb -> ide_bus_register_restart_cb Philippe Mathieu-Daudé
2023-02-15 19:13 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 13/20] hw/ide: Rename ide_exec_cmd() -> ide_bus_exec_cmd() Philippe Mathieu-Daudé
2023-02-15 19:14 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 14/20] hw/ide: Rename ide_init2() -> ide_bus_init_output_irq() Philippe Mathieu-Daudé
2023-02-15 15:40 ` Philippe Mathieu-Daudé
2023-02-15 19:15 ` Richard Henderson
2023-02-16 0:10 ` Bernhard Beschow
2023-02-15 11:27 ` [PATCH 15/20] hw/ide: Rename idebus_active_if() -> ide_bus_active_if() Philippe Mathieu-Daudé
2023-02-15 19:16 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 16/20] hw/ide/ioport: Remove unnecessary includes Philippe Mathieu-Daudé
2023-02-15 19:17 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 17/20] hw/ide/pci: Unexport bmdma_active_if() Philippe Mathieu-Daudé
2023-02-15 18:13 ` Bernhard Beschow
2023-02-15 21:09 ` BALATON Zoltan
2023-02-16 0:18 ` Bernhard Beschow
2023-02-16 0:33 ` Bernhard Beschow
2023-02-15 19:17 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 18/20] hw/ide/piix: Remove unused includes Philippe Mathieu-Daudé
2023-02-15 19:18 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 19/20] hw/ide/piix: Pass Error* to pci_piix_init_ports() for better error msg Philippe Mathieu-Daudé
2023-02-15 19:20 ` Richard Henderson
2023-02-15 11:27 ` [PATCH 20/20] hw/ide/piix: Refactor pci_piix_init_ports as pci_piix_init_bus per bus Philippe Mathieu-Daudé
2023-02-15 19:21 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9bca328-5c27-0c55-8ccc-a2df40b61ae9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).