From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] decodetree: Improve identifier matching
Date: Thu, 3 Sep 2020 22:04:04 +0200 [thread overview]
Message-ID: <a9ce75e9-187c-1a39-6bc6-58f2bae3512f@amsat.org> (raw)
In-Reply-To: <20200903192334.1603773-1-richard.henderson@linaro.org>
On 9/3/20 9:23 PM, Richard Henderson wrote:
> Only argument set members have to be C identifiers, everything
> else gets prefixed during conversion to C. Some places just
> checked the leading character, and some places matched a leading
> character plus a C identifier.
>
> Convert everything to match full identifiers, including the
> [&%@&] prefix, and drop the full C identifier requirement.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/decode/succ_ident1.decode | 7 +++++
> scripts/decodetree.py | 46 +++++++++++++++++++++------------
> 2 files changed, 37 insertions(+), 16 deletions(-)
> create mode 100644 tests/decode/succ_ident1.decode
next prev parent reply other threads:[~2020-09-03 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 19:23 [PATCH] decodetree: Improve identifier matching Richard Henderson
2020-09-03 20:04 ` Philippe Mathieu-Daudé [this message]
2020-09-10 19:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9ce75e9-187c-1a39-6bc6-58f2bae3512f@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).