From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F227AC433E9 for ; Thu, 3 Sep 2020 20:05:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B047F20709 for ; Thu, 3 Sep 2020 20:05:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sjOgHuv+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B047F20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDvTg-0001aM-Pz for qemu-devel@archiver.kernel.org; Thu, 03 Sep 2020 16:05:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDvSr-00018Z-KE for qemu-devel@nongnu.org; Thu, 03 Sep 2020 16:04:09 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:32902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDvSp-0005yE-MA for qemu-devel@nongnu.org; Thu, 03 Sep 2020 16:04:09 -0400 Received: by mail-wr1-x444.google.com with SMTP id m6so4553073wrn.0 for ; Thu, 03 Sep 2020 13:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VxzcOFwvfxWFMxA2FklTQ1ssgqomY69A9vmyuWDxiOI=; b=sjOgHuv+SydbN0POXx4zokYkQ9j8ZO+BmrVQ5bWmLkjpTvwlEV/mmp5mj7uJVqSgh8 4hWGKnugvwcTNb2TjXW9PwEB7Xp5oHYLlCfKLLBfhtuJJ0WLZ7EH8J87VeTbd1h3Tz0p Rr/7fafssXFOAKk8N9sQfgh2Egz8DDQFa2OnronJQZmHylgXMBSHH7kSFH5jiB0MbzR3 2/n5kUOcek8pkjJnvcUK5HCeATKoSivbdfUkInu5ifdWXjtyrw7KXyIA9eu0zoYg5v83 jwv9oRpB153ayZvJSYmw6v7Y7htKBE9ngRUUYOBpe1ADpmMCSRpV4HbG5z+3rqnzPfUz kahw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VxzcOFwvfxWFMxA2FklTQ1ssgqomY69A9vmyuWDxiOI=; b=bWL3UGfQfhfo0lQepyrEgKhu9uihi8kx9mDEV/YdFvSHzY3faxhDAOcjYXnSWQtv8k xY89YdJyq81KlTY8/Q39XdCPr5SvUqTwPALVCZxqfGJ2MdFeTQMd4vO38Fd9ZWZw+nZT XM8/36oCVzxZU7202kBTYgutoPr6vsqDmbYqwDO/WT/rL6B9z3LAZlac9h1d9js65Mma b1LVDmCWYYpvz7WQ+V9HF3heJF1IUMePVZdjBBcHiqEj4bVF8/VLYHIEGNV7FbgijE8n 7Ck7CvyFBhGrNOlYyw+eXc80i7sjUa4pv9ClISfcPMk319lJjCXqjEfhXVbC/ZbRHRgm /xCA== X-Gm-Message-State: AOAM53032FIWSTEXpAAFm8yRyISdEaMyhR6vcw99foryb66E60BVxzYm mkcz7+GVbJvB+Q88uS6iZ0A= X-Google-Smtp-Source: ABdhPJzcu8UFS2tZ6/c0TNfXNkdoJ/832VNkUuFXqjsa6ZYZfeTFRSiRtiOu0S7zqCnwIxBDt8csPw== X-Received: by 2002:adf:f189:: with SMTP id h9mr4153527wro.122.1599163446011; Thu, 03 Sep 2020 13:04:06 -0700 (PDT) Received: from [192.168.1.36] (50.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.50]) by smtp.gmail.com with ESMTPSA id v3sm6125863wmh.6.2020.09.03.13.04.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2020 13:04:05 -0700 (PDT) Subject: Re: [PATCH] decodetree: Improve identifier matching To: Richard Henderson , qemu-devel@nongnu.org References: <20200903192334.1603773-1-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 3 Sep 2020 22:04:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200903192334.1603773-1-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, NICE_REPLY_A=-2.403, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/3/20 9:23 PM, Richard Henderson wrote: > Only argument set members have to be C identifiers, everything > else gets prefixed during conversion to C. Some places just > checked the leading character, and some places matched a leading > character plus a C identifier. > > Convert everything to match full identifiers, including the > [&%@&] prefix, and drop the full C identifier requirement. > > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > tests/decode/succ_ident1.decode | 7 +++++ > scripts/decodetree.py | 46 +++++++++++++++++++++------------ > 2 files changed, 37 insertions(+), 16 deletions(-) > create mode 100644 tests/decode/succ_ident1.decode