Re: [Qemu-devel] [PULL 06/16] migration: add postcopy total blocktime into query-migrate

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

On 04/25/2018 03:03 PM, Dr. David Alan Gilbert (git) wrote:
> From: Alexey Perevalov <a.perevalov@samsung.com>
> 
> Postcopy total blocktime is available on destination side only.
> But query-migrate was possible only for source. This patch
> adds ability to call query-migrate on destination.
> To be able to see postcopy blocktime, need to request postcopy-blocktime
> capability.

This prerequisite command...


> +++ b/qapi/migration.json
> @@ -155,6 +155,13 @@
>  # @error-desc: the human readable error description string, when
>  #              @status is 'failed'. Clients should not attempt to parse the
>  #              error strings. (Since 2.7)
> +#
> +# @postcopy-blocktime: total time when all vCPU were blocked during postcopy
> +#           live migration (Since 2.13)
> +#
> +# @postcopy-vcpu-blocktime: list of the postcopy blocktime per vCPU (Since 2.13)

... should be documented here (something along the lines of "This field
is only present if the postcopy-blocktime migration capability was enabled")

> +#
> +
>  #

Why the blank line addition?  More to include in your followup cleanup
patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]