From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4151C0018C for ; Wed, 16 Dec 2020 20:02:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F47020578 for ; Wed, 16 Dec 2020 20:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F47020578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpd0Y-0007J3-Am for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 15:02:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpcux-0001BK-DK for qemu-devel@nongnu.org; Wed, 16 Dec 2020 14:56:59 -0500 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:34301) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpcuv-0005Fe-W6 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 14:56:59 -0500 Received: by mail-ot1-x330.google.com with SMTP id a109so24368564otc.1 for ; Wed, 16 Dec 2020 11:56:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iVsgdlU49PhgitUe3lBsmw7IoIfh2xXHyqLGZvpLZTU=; b=daz5Uf1MbPffn8zQC6S46OIU1fNVrltJG+8s/sa/ImpPaEC90mk13Fuw8WHWqRfDcf 9BD0/JaCUaw/AHEmFzBLKCy5yMPvzb0L7fra83eCaoHsvr2DG+0V1p28ot7LpWzP040k w04amT8IC2SEnB18+9yYuJKoeT4E2UUTa69UPlEtGX0hSDA89YyEQKRu3z+NaJ0N4Jjq aMUoI7/8mAAZibvvEhaw7yH8oXEIbbMLWZC4ZFiuyn8WmihEtgnrXXIdtPro5JVERFCG 6x8lN7vMSOVeZ4/DPKLBMGTg2xLcdnW0XwbgVsuGG46IQPxBqUkFQU8WPTJ86vecqggD sI/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iVsgdlU49PhgitUe3lBsmw7IoIfh2xXHyqLGZvpLZTU=; b=eFF1qEs0JF59i+ObZV+MtOfkOVMH63Le3qBWccj6H0pEPshkZiE0g2HurJxOQHlTzr 6BA74RQ9x3M6Dl34y6qhalFYm1AoaK/8BhcNZ+b0YfP3d2n+2RJ2zHeMgJ35+gbAqrbp /I3RwVe1TJ6piagzUAgKO5p21lLQr5GRoRaDKdYUpfmXPGuaLuTzs6Zp+Mux4UlGc31k wDDX0dc+6yZa8hHK+g2Ncdrn3DsDHNWjtL+L6z+TdkKpBV4fp0DNinq1YvwYzCB7rSQ0 s/rY/624cHgTbqVCc2ITHwm4T1m+SXAHWmUK+7f/Za76N4VeqPLei4kM2x/ya2GuirQO cR1Q== X-Gm-Message-State: AOAM531f507IriUowsYGKzEF3mtZzXgwQ9mjNboQMj6D7jxkmYjF2TQw KtYUTNLgzradLn7WIGsPdh/tUQ== X-Google-Smtp-Source: ABdhPJxX/4GN48qZQ6649uHIn12Dg9foFxOYe1CqLL/Irci4l2+u/QH/QsEix1RrjKNj2FmE2xT7CQ== X-Received: by 2002:a9d:508:: with SMTP id 8mr27363646otw.338.1608148616903; Wed, 16 Dec 2020 11:56:56 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id 11sm663690oty.65.2020.12.16.11.56.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 11:56:56 -0800 (PST) Subject: Re: [PATCH v1 6/6] gdbstub: ensure we clean-up when terminated To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20201214153012.12723-1-alex.bennee@linaro.org> <20201214153012.12723-7-alex.bennee@linaro.org> From: Richard Henderson Message-ID: Date: Wed, 16 Dec 2020 13:56:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201214153012.12723-7-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/14/20 9:30 AM, Alex Bennée wrote: > If you kill the inferior from GDB we end up leaving our socket lying > around. Fix this by calling gdb_exit() first. > > Signed-off-by: Alex Bennée > --- > gdbstub.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson r~