Re: [PATCH v2 2/3] migration: Make save_snapshot() return bool, not 0/-1

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 10/21/20 11:56 AM, Daniel P. Berrangé wrote:
> On Mon, Oct 12, 2020 at 02:27:42PM +0200, Philippe Mathieu-Daudé wrote:
>> Just for consistency, following the example documented since
>> commit e3fe3988d7 ("error: Document Error API usage rules"),
>> return a boolean value indicating an error is set or not.
>>
>> Acked-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>   include/migration/snapshot.h |  9 ++++++++-
>>   migration/savevm.c           | 16 ++++++++--------
>>   replay/replay-debugging.c    |  2 +-
>>   replay/replay-snapshot.c     |  2 +-
>>   4 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/include/migration/snapshot.h b/include/migration/snapshot.h
>> index c85b6ec75b7..a40c34307b5 100644
>> --- a/include/migration/snapshot.h
>> +++ b/include/migration/snapshot.h
>> @@ -15,7 +15,14 @@
>>   #ifndef QEMU_MIGRATION_SNAPSHOT_H
>>   #define QEMU_MIGRATION_SNAPSHOT_H
>>   
>> -int save_snapshot(const char *name, Error **errp);
>> +/**
>> + * save_snapshot: Save a snapshot.
>> + * @name: path to snapshot
> 
> This isn't a path, it is a name.
> 
> I'll apply this change:
> 
>    - * save_snapshot: Save a snapshot.
>    - * @name: path to snapshot
>    + * save_snapshot: Save an internal snapshot.
>    + * @name: name of internal snapshot

Thanks!