From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: clg@kaod.org, david@gibson.dropbear.id.au, groug@kaod.org,
richard.henderson@linaro.org, matheus.ferst@eldorado.org.br,
lucas.araujo@eldorado.org.br, leandro.lupori@eldorado.org.br,
lucas.coutinho@eldorado.org.br
Subject: Re: [PATCH] target/ppc: Fix xvcmp* clearing FI bit
Date: Fri, 14 Oct 2022 07:25:07 -0300 [thread overview]
Message-ID: <a9e1f48a-f192-1c1e-aee9-674bdab935ea@gmail.com> (raw)
In-Reply-To: <20221005121551.27957-1-victor.colombo@eldorado.org.br>
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 10/5/22 09:15, Víctor Colombo wrote:
> Vector instructions in general are not supposed to change the FI bit.
> However, xvcmp* instructions are calling gen_helper_float_check_status,
> which is leading to a cleared FI flag where it should be kept
> unchanged.
> As helper_float_check_status only affects inexact, overflow and
> underflow, and the xvcmp* instructions don't change these flags, this
> issue can be fixed by removing the call to helper_float_check_status.
> By doing this, the FI bit in FPSCR will be preserved as expected.
>
> Fixes: 00084a25adf ("target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions")
> Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
> ---
> target/ppc/translate/vsx-impl.c.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc
> index 7acdbceec4..e6e5c45ffd 100644
> --- a/target/ppc/translate/vsx-impl.c.inc
> +++ b/target/ppc/translate/vsx-impl.c.inc
> @@ -810,7 +810,6 @@ static void gen_##name(DisasContext *ctx) \
> gen_helper_##name(ignored, cpu_env, xt, xa, xb); \
> tcg_temp_free_i32(ignored); \
> } \
> - gen_helper_float_check_status(cpu_env); \
> tcg_temp_free_ptr(xt); \
> tcg_temp_free_ptr(xa); \
> tcg_temp_free_ptr(xb); \
prev parent reply other threads:[~2022-10-14 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 12:15 [PATCH] target/ppc: Fix xvcmp* clearing FI bit Víctor Colombo
2022-10-05 13:51 ` Richard Henderson
2022-10-14 10:25 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e1f48a-f192-1c1e-aee9-674bdab935ea@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=leandro.lupori@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=lucas.coutinho@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).