From: Richard Henderson <richard.henderson@linaro.org>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, laurent@vivier.eu, riku.voipio@iki.fi,
philippe.mathieu.daude@gmail.com, aurelien@aurel32.net,
amarkovic@wavecomp.com, smarkovic@wavecomp.com,
pjovanovic@wavecomp.com, pburton@wavecomp.com
Subject: [Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4
Date: Thu, 16 Aug 2018 10:26:30 -0700 [thread overview]
Message-ID: <a9e4794e-ed53-f9d8-8809-3e61215bbd37@linaro.org> (raw)
In-Reply-To: <1534431497-1385-46-git-send-email-aleksandar.markovic@rt-rk.com>
On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> + switch (opc) {
> + case NM_POOL32AXF_2_0_7:
> + switch (extract32(ctx->opcode, 9, 3)) {
For future cleanup, I can't help but thinking you'd be better served by
extracting a different set of opcode bits and having a single switch.
That said, it all appears to all be correct, so
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-08-16 17:26 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 14:56 [Qemu-devel] [PATCH v9 00/84] Add nanoMIPS support to QEMU Aleksandar Markovic
2018-08-16 14:56 ` [Qemu-devel] [PATCH v9 01/84] MAINTAINERS: Update target/mips maintainer's email addresses Aleksandar Markovic
2018-08-16 14:56 ` [Qemu-devel] [PATCH v9 02/84] target/mips: Avoid case statements formulated by ranges - part 1 Aleksandar Markovic
2018-08-16 14:56 ` [Qemu-devel] [PATCH v9 03/84] target/mips: Avoid case statements formulated by ranges - part 2 Aleksandar Markovic
2018-08-16 15:53 ` Richard Henderson
2018-08-16 14:56 ` [Qemu-devel] [PATCH v9 04/84] target/mips: Mark switch fallthroughs with interpretable comments Aleksandar Markovic
2018-08-16 14:56 ` [Qemu-devel] [PATCH v9 05/84] target/mips: Fix two instances of shadow variables Aleksandar Markovic
2018-08-16 14:56 ` [Qemu-devel] [PATCH v9 06/84] target/mips: Update some CP0 registers bit definitions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 07/84] target/mips: Add CP0 BadInstrX register Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 08/84] target/mips: Implement CP0 Config1.WR bit functionality Aleksandar Markovic
2018-08-16 15:54 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 09/84] target/mips: Don't update BadVAddr register in Debug Mode Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 10/84] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0 Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 11/84] elf: Remove duplicate preprocessor constant definition Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 12/84] elf: Add ELF flags for MIPS machine variants Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 13/84] linux-user: Update MIPS syscall numbers up to kernel 4.18 headers Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 14/84] linux-user: Add preprocessor availability control to some syscalls Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 15/84] qemu-doc: Amend MIPS-related items Aleksandar Markovic
2018-08-16 15:58 ` Richard Henderson
2018-08-16 16:51 ` Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 16/84] target/mips: Add preprocessor constants for nanoMIPS Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 17/84] target/mips: Add nanoMIPS base instruction set opcodes Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 18/84] target/mips: Add nanoMIPS DSP ASE opcodes Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 19/84] target/mips: Add placeholder and invocation of decode_nanomips_opc() Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 20/84] target/mips: Add nanoMIPS decoding and extraction utilities Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 21/84] target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 22/84] target/mips: Add emulation of nanoMIPS 16-bit branch instructions Aleksandar Markovic
2018-08-16 16:33 ` Richard Henderson
2018-08-16 16:46 ` Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 23/84] target/mips: Add emulation of nanoMIPS 16-bit shift instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 24/84] target/mips: Add emulation of nanoMIPS 16-bit misc instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 25/84] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 26/84] target/mips: Add emulation of nanoMIPS 16-bit logic instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 27/84] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 28/84] target/mips: Add emulation of some common nanoMIPS 32-bit instructions Aleksandar Markovic
2018-08-16 16:11 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 29/84] target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 30/84] target/mips: Add emulation of nanoMIPS 48-bit instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 31/84] target/mips: Add emulation of nanoMIPS FP instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 32/84] target/mips: Add emulation of misc nanoMIPS instructions (pool32a0) Aleksandar Markovic
2018-08-16 16:13 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 33/84] target/mips: Add emulation of misc nanoMIPS instructions (pool32axf) Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 34/84] target/mips: Add emulation of misc nanoMIPS instructions (p_lsx) Aleksandar Markovic
2018-08-16 16:14 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 35/84] target/mips: Implement emulation of nanoMIPS ROTX instruction Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 36/84] target/mips: Implement emulation of nanoMIPS EXTW instruction Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 37/84] target/mips: Add emulation of nanoMIPS 32-bit load and store instructions Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 38/84] target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair Aleksandar Markovic
2018-08-16 16:20 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 39/84] target/mips: Add emulation of nanoMIPS 32-bit branch instructions Aleksandar Markovic
2018-08-16 16:31 ` Richard Henderson
2018-08-16 16:55 ` Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 40/84] target/mips: Fix pre-nanoMIPS MT ASE instructions availability control Aleksandar Markovic
2018-08-16 16:37 ` Richard Henderson
2018-08-16 17:06 ` Aleksandar Markovic
2018-08-16 17:22 ` Richard Henderson
2018-08-17 13:48 ` Aleksandar Markovic
2018-08-21 12:33 ` Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 41/84] target/mips: Implement MT ASE support for nanoMIPS Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 42/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1 Aleksandar Markovic
2018-08-16 16:40 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 43/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 2 Aleksandar Markovic
2018-08-16 16:42 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 44/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 3 Aleksandar Markovic
2018-08-16 16:43 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4 Aleksandar Markovic
2018-08-16 17:26 ` Richard Henderson [this message]
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 46/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 5 Aleksandar Markovic
2018-08-16 17:36 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 47/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 6 Aleksandar Markovic
2018-08-16 17:38 ` Richard Henderson
2018-08-17 14:19 ` Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 48/84] disas: Add support for microMIPS and nanoMIPS Aleksandar Markovic
2018-08-16 17:57 ` Richard Henderson
2018-08-17 14:14 ` Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 49/84] target/mips: Add handling of ISA mode bit for nanoMIPS Aleksandar Markovic
2018-08-16 19:08 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 50/84] target/mips: Add updating BadInstr, BadInstrP, BadInstrX " Aleksandar Markovic
2018-08-16 19:29 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 51/84] target/mips: Adjust exception_resume_pc() " Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 52/84] target/mips: Adjust set_hflags_for_handler() " Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 53/84] target/mips: Adjust set_pc() " Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 54/84] target/mips: Fix ERET/ERETNC behavior related to ADEL exception Aleksandar Markovic
2018-08-16 19:34 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 55/84] elf: Add EM_NANOMIPS value as a valid one for e_machine field Aleksandar Markovic
2018-08-16 19:34 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 56/84] elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 57/84] elf: Don't check FCR31_NAN2008 bit for nanoMIPS Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 58/84] elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS as legal for MIPS Aleksandar Markovic
2018-08-16 19:50 ` Richard Henderson
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 59/84] mips_malta: Add basic nanoMIPS boot code for Malta board Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 60/84] mips_malta: Add setting up GT64120 BARs to the nanoMIPS bootloader Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 61/84] mips_malta: Fix semihosting argument passing for nanoMIPS bare metal Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 62/84] target/mips: Add definition of nanoMIPS I7200 CPU Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 63/84] elf: Add nanoMIPS specific variations in ELF header fields Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 64/84] linux-user: Add syscall numbers for nanoMIPS Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 65/84] linux-user: Add target_signal.h header " Aleksandar Markovic
2018-08-16 14:57 ` [Qemu-devel] [PATCH v9 66/84] linux-user: Add termbits.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 67/84] linux-user: Update syscall_defs.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 68/84] linux-user: Add target_fcntl.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 69/84] linux-user: Add sockbits.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 70/84] linux-user: Add target_syscall.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 71/84] linux-user: Add target_cpu.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 72/84] linux-user: Add target_structs.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 73/84] linux-user: Add target_elf.h " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 74/84] linux-user: Add signal.c " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 75/84] linux-user: Add support for nanoMIPS signal trampoline Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 76/84] linux-user: Add cpu_loop.c for nanoMIPS Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 77/84] linux-user: Amend support for sigaction() syscall " Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 78/84] linux-user: Add support for statx() syscall for all platforms Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 79/84] linux-user: Add support for nanoMIPS core files Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 80/84] linux-user: Add nanoMIPS linux user mode configuration support Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 81/84] linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 82/84] gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 83/84] gdbstub: Add XML support for GDB for nanoMIPS Aleksandar Markovic
2018-08-16 14:58 ` [Qemu-devel] [PATCH v9 84/84] qemu-doc: Add nanoMIPS-related items Aleksandar Markovic
2018-08-17 17:45 ` [Qemu-devel] [PATCH v9 00/84] Add nanoMIPS support to QEMU no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e4794e-ed53-f9d8-8809-3e61215bbd37@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.markovic@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=laurent@vivier.eu \
--cc=pburton@wavecomp.com \
--cc=peter.maydell@linaro.org \
--cc=philippe.mathieu.daude@gmail.com \
--cc=pjovanovic@wavecomp.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=smarkovic@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).