From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52258C433E0 for ; Thu, 25 Jun 2020 06:34:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 103CF20706 for ; Thu, 25 Jun 2020 06:34:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MemzwgjU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 103CF20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joLTG-0001XX-3p for qemu-devel@archiver.kernel.org; Thu, 25 Jun 2020 02:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joLRm-0000m7-26 for qemu-devel@nongnu.org; Thu, 25 Jun 2020 02:33:21 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:56534 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joLRc-0006on-TO for qemu-devel@nongnu.org; Thu, 25 Jun 2020 02:33:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593066787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UnIfmBlF3xcBuUxzi0YvyM2YzbPh/A7xvWaU2zcAZFs=; b=MemzwgjUfRd+AUVPFDpOo91Y5qrtNf4TzU6a3dDfoz7df7TR2OPmAZkwjlWEtRQN3m9385 xGWQPoRVYjwoEJ2GCDmPa6Qqlr85/qQo9ldvpBMCn2CP45v+SPhGnEhuGtq0/T0WzM5RkY LklQYWPdGrYD7bYGdhWsqNV/lhFP2vY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-nQiNazggMRafQamY05Xa_Q-1; Thu, 25 Jun 2020 02:33:06 -0400 X-MC-Unique: nQiNazggMRafQamY05Xa_Q-1 Received: by mail-wr1-f69.google.com with SMTP id y16so6080496wrr.20 for ; Wed, 24 Jun 2020 23:33:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UnIfmBlF3xcBuUxzi0YvyM2YzbPh/A7xvWaU2zcAZFs=; b=T3jA+lBHtnPrXjnVb6TuhMVfv6hG82BWc/jnkrAJPCesLUQmfiFsiw6iHXNv9wZTJc hf/UmRL/1IrlVs8GU+UFe9h+Aoq4tVCOMbyVVsYf6xD/tittjV7f7SaQfHWZdLCjPo61 ZLNKKwYfEVH0lxD7zVA1iNombg0F2XV37Z/HLoYwvpqn6yY7TV79pBFWJaeUcAsRlkIY nb0NnyxOc7EcBjgHu9rypUL0ndfUf6Z39fQ/8UuPEDUyB5SUgfJ2xD5UVTMl41XQurMG 6JIbT6lI+lsYzsjvRx+z14eq6YNAXpiPKUFK4LodhOWmlTvOq+phvV1ECJaI5YgKHSB9 rRjQ== X-Gm-Message-State: AOAM530hYml4bGjQNJlObhdTxFENU8oJ46D/T2JgDL3bKUg12Q3B7c38 7YurbsxvED4yWworrAIs3b80yFQmj2STv1+iwtOWZr0g3VXMJBy4w3nWXIT0Es26TMjYJdyZDkC XmXIklup171PK/YU= X-Received: by 2002:adf:9205:: with SMTP id 5mr33259143wrj.232.1593066785271; Wed, 24 Jun 2020 23:33:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeH7BwiT8wPQ3xvkFbgCQd0AOO9bZgzS2e6x+lHnXuNQoaf/sBcetfqSqqm+oUdR9+hvLhiA== X-Received: by 2002:adf:9205:: with SMTP id 5mr33259111wrj.232.1593066785029; Wed, 24 Jun 2020 23:33:05 -0700 (PDT) Received: from [192.168.1.40] (1.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.1]) by smtp.gmail.com with ESMTPSA id a16sm29373330wrx.8.2020.06.24.23.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2020 23:33:04 -0700 (PDT) Subject: Re: [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type() To: Markus Armbruster , qemu-devel@nongnu.org References: <20200624164344.3778251-1-armbru@redhat.com> <20200624164344.3778251-33-armbru@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Thu, 25 Jun 2020 08:33:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200624164344.3778251-33-armbru@redhat.com> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 01:47:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, vsementsov@virtuozzo.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/24/20 6:43 PM, Markus Armbruster wrote: > Commit 2f262e06f0 lifted qdev_get_type() from qdev to object without > renaming it accordingly. Do that now. > > Signed-off-by: Markus Armbruster > --- > qom/object.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index b8aac074c2..f6e9f0e413 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -2359,7 +2359,7 @@ object_class_property_add_tm(ObjectClass *klass, const char *name, > NULL, NULL, prop); > } > > -static char *qdev_get_type(Object *obj, Error **errp) > +static char *object_get_type(Object *obj, Error **errp) > { > return g_strdup(object_get_typename(obj)); > } > @@ -2702,7 +2702,7 @@ void object_class_property_set_description(ObjectClass *klass, > > static void object_class_init(ObjectClass *klass, void *data) > { > - object_class_property_add_str(klass, "type", qdev_get_type, > + object_class_property_add_str(klass, "type", object_get_type, > NULL); > } > > Reviewed-by: Philippe Mathieu-Daudé