qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads
Date: Sat, 3 Mar 2018 06:13:37 -0800	[thread overview]
Message-ID: <a9fb7f08-9eeb-4120-620e-1f05715ee329@twiddle.net> (raw)
In-Reply-To: <CAE5jQCcCA=3kkVa=5eMZs-BGAM_p4fZG+GPu1SmQMg7_sPAH5Q@mail.gmail.com>

On 03/03/2018 06:07 AM, Anatoly Trosinenko wrote:
> Can rewriting TCI in such a way that every operation is aligned at 4- or even
> 8-byte boundary fix the situation or are there some more serious problems?

With the current TCI, there are also problems with calls to helper functions.
The only portable way to do this is to use a library such as libffi.

I once rewrote TCI completely in order to address both problems, but that only
brought questions as to why TCI is useful at all.

So.  Why do you want to use TCI instead of a native TCG backend?


r~

  reply	other threads:[~2018-03-03 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-27 13:49 [Qemu-devel] [PATCH 0/1] Fix unaligned reads in the tcg/tci.c Anatoly Trosinenko
2018-01-27 13:49 ` [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads Anatoly Trosinenko
2018-01-27 16:38   ` Stefan Weil
2018-01-28  6:42     ` Anatoly Trosinenko
2018-02-19 14:26       ` Anatoly Trosinenko
2018-03-03  8:54       ` Anatoly Trosinenko
2018-03-03 13:57         ` Richard Henderson
2018-03-03 14:07           ` Anatoly Trosinenko
2018-03-03 14:13             ` Richard Henderson [this message]
2018-03-03 14:59               ` Anatoly Trosinenko
2018-03-03 15:41             ` Stefan Weil
2018-03-03 16:01               ` Anatoly Trosinenko
2018-03-12 13:45               ` Richard Henderson
2018-02-05 13:52 ` [Qemu-devel] [PATCH 0/1] Fix unaligned reads in the tcg/tci.c Anatoly Trosinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9fb7f08-9eeb-4120-620e-1f05715ee329@twiddle.net \
    --to=rth@twiddle.net \
    --cc=anatoly.trosinenko@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).