From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B939C369CB for ; Wed, 23 Apr 2025 12:44:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7ZS9-0007cx-Dl; Wed, 23 Apr 2025 08:43:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7ZS7-0007cH-Ap for qemu-devel@nongnu.org; Wed, 23 Apr 2025 08:43:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7ZS5-00052r-IC for qemu-devel@nongnu.org; Wed, 23 Apr 2025 08:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745412224; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=mgFPqKGRSsBriFgimtMnpIDJSgOXnpl/SOH6PhuFgNM=; b=FuiMGU4RyIlN+WVMgNhazVXbu6MdUc37Y7FBvzzK6SZGh6IQNT5sAVBRgV/K96vpN69wrj uOqti3a8LyKfkSaLhuaPbyRcakagcDPO6HJgoT8loWDJUatG0Qxv2TT2hVOnzq1pZlUMlS DqjOOSy8i6wWLal0gonBYep9qyUUTow= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-6U6CC2vfNNadCfepZ3R3Bw-1; Wed, 23 Apr 2025 08:43:42 -0400 X-MC-Unique: 6U6CC2vfNNadCfepZ3R3Bw-1 X-Mimecast-MFC-AGG-ID: 6U6CC2vfNNadCfepZ3R3Bw_1745412221 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9042E19560AA; Wed, 23 Apr 2025 12:43:41 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.34]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DE938195608D; Wed, 23 Apr 2025 12:43:39 +0000 (UTC) Date: Wed, 23 Apr 2025 13:43:36 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dietmar Maurer Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Subject: Re: [PATCH v3 4/9] h264: search for available h264 encoder Message-ID: References: <20250418112953.1744442-1-dietmar@proxmox.com> <20250418112953.1744442-5-dietmar@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250418112953.1744442-5-dietmar@proxmox.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.294, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Apr 18, 2025 at 01:29:48PM +0200, Dietmar Maurer wrote: > The search list is currently hardcoded to: ["x264enc", "openh264enc"] > > x264enc: is probably the best available software encoder > openh264enc: lower quality, but available on more systems. > > We restrict encoders to a known list because each encoder requires > fine tuning to get reasonable/usable results. > > Signed-off-by: Dietmar Maurer > --- > ui/vnc-enc-h264.c | 89 +++++++++++++++++++++++++++++++++++++++-------- > ui/vnc.h | 1 + > 2 files changed, 75 insertions(+), 15 deletions(-) > > diff --git a/ui/vnc-enc-h264.c b/ui/vnc-enc-h264.c > index 3abe6a1528..047f4a3128 100644 > --- a/ui/vnc-enc-h264.c > +++ b/ui/vnc-enc-h264.c > @@ -27,6 +27,68 @@ > > #include > > +const char *encoder_list[] = { "x264enc", "openh264enc", NULL }; > + > +static const char *get_available_encoder(void) > +{ > + int i = 0; > + do { > + const char *encoder_name = encoder_list[i]; > + if (encoder_name == NULL) { > + break; > + } > + GstElement *element = gst_element_factory_make( > + encoder_name, "video-encoder"); > + if (element != NULL) { > + gst_object_unref(element); > + return encoder_name; > + } > + i = i + 1; > + } while (true); This while loop is incredibly verbose as written. for (int i = 0; i < G_N_ELEMENTS(encoder_list); i++) { GstElement *element = gst_element_factory_make( encoder_list[i], "video-encoder"); if (element != NULL) { gst_object_unref(element); return encoder_list[i]; } } and get rid of the trailing "NULL" in encoder_list as it isn't required > + > + return NULL; > +} > + With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|