From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2AFBC369CB for ; Wed, 23 Apr 2025 12:53:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7Zap-00040b-CQ; Wed, 23 Apr 2025 08:52:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Zan-000409-Li for qemu-devel@nongnu.org; Wed, 23 Apr 2025 08:52:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Zal-00066i-5c for qemu-devel@nongnu.org; Wed, 23 Apr 2025 08:52:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745412760; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=uM9YKiHGsm/d60SWaEm/jEGa3bibpel2zwiDQc91p5M=; b=IDzWRsV+VVXAyVQI1qmJX71OnVugy1mOOLe464pdkcLzd2GPUT6t4oF9NUdxiC3xwU5Fx6 I1s1GdWDMw/TQZoMhzDmBmUN7PSSByfvtUvGeVW9ti25ikHpzpsuqA6GtcLNBOdAr6WiMn +uer5o9FnQz1eEyMzsaG17T8fnChXpg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-acFEklAuPNOIFGQ-j2nMsw-1; Wed, 23 Apr 2025 08:52:38 -0400 X-MC-Unique: acFEklAuPNOIFGQ-j2nMsw-1 X-Mimecast-MFC-AGG-ID: acFEklAuPNOIFGQ-j2nMsw_1745412757 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D2F631800878; Wed, 23 Apr 2025 12:52:37 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.34]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DA3281800378; Wed, 23 Apr 2025 12:52:35 +0000 (UTC) Date: Wed, 23 Apr 2025 13:52:32 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dietmar Maurer Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Subject: Re: [PATCH v3 8/9] vnc: initialize gst during argument processing Message-ID: References: <20250418112953.1744442-1-dietmar@proxmox.com> <20250418112953.1744442-9-dietmar@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250418112953.1744442-9-dietmar@proxmox.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.294, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Apr 18, 2025 at 01:29:52PM +0200, Dietmar Maurer wrote: > So that we can set --gst- options on the qemu command line. I don't think this is desirable. It exposes a bunch of arbitrary command line arguments that QEMU has no visibility or control over. This will complicate our long term work / goal of moving all QEMU configuration to QMP. CC Markus for a 2nd opinion as our command line modelling / QMP expert. > > Signed-off-by: Dietmar Maurer > --- > system/vl.c | 8 ++++++++ > ui/vnc.c | 4 ---- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/system/vl.c b/system/vl.c > index ec93988a03..c7fff02da2 100644 > --- a/system/vl.c > +++ b/system/vl.c > @@ -140,6 +140,10 @@ > #include "qemu/guest-random.h" > #include "qemu/keyval.h" > > +#ifdef CONFIG_GSTREAMER > +#include > +#endif > + > #define MAX_VIRTIO_CONSOLES 1 > > typedef struct BlockdevOptionsQueueEntry { > @@ -2848,6 +2852,10 @@ void qemu_init(int argc, char **argv) > bool userconfig = true; > FILE *vmstate_dump_file = NULL; > > +#ifdef CONFIG_GSTREAMER > + gst_init(&argc, &argv); > +#endif > + > qemu_add_opts(&qemu_drive_opts); > qemu_add_drive_opts(&qemu_legacy_drive_opts); > qemu_add_drive_opts(&qemu_common_drive_opts); > diff --git a/ui/vnc.c b/ui/vnc.c > index 6db03a1550..8f6287e2e6 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -4350,10 +4350,6 @@ int vnc_init_func(void *opaque, QemuOpts *opts, Error **errp) > Error *local_err = NULL; > char *id = (char *)qemu_opts_id(opts); > > -#ifdef CONFIG_GSTREAMER > - gst_init(NULL, NULL); > -#endif > - > assert(id); > vnc_display_init(id, &local_err); > if (local_err) { > -- > 2.39.5 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|