From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1B03C369D8 for ; Wed, 23 Apr 2025 13:34:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7aEG-0002tP-12; Wed, 23 Apr 2025 09:33:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7aE5-0002s9-Hn for qemu-devel@nongnu.org; Wed, 23 Apr 2025 09:33:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7aE2-0003TR-NN for qemu-devel@nongnu.org; Wed, 23 Apr 2025 09:33:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745415197; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QBssnThr5+a6ySikuLEHXfuSBEGKnsqBxCejsr/ht5k=; b=I5cou6VMUf5QoU+HNMApJVxBl3g1RYyfAMPnRFuXx9Qkpy0IDczpfXvjcLigGqC+awYtDh 7vCsjCZ8JcK3fM7oTM1F0i/n66o+aDSXuDY1a6vFAKG4TsO3EQexaL+KKYTCTB6h1hcXdP 73WXHPt6vGFTux18tfc+912z9tOKFec= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-UbkyYZcVOtiADd4ciWaCrQ-1; Wed, 23 Apr 2025 09:33:12 -0400 X-MC-Unique: UbkyYZcVOtiADd4ciWaCrQ-1 X-Mimecast-MFC-AGG-ID: UbkyYZcVOtiADd4ciWaCrQ_1745415190 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 40AFE1800EC9; Wed, 23 Apr 2025 13:33:10 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.34]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4007A180047F; Wed, 23 Apr 2025 13:33:05 +0000 (UTC) Date: Wed, 23 Apr 2025 14:33:02 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Zhao Liu , Paolo Bonzini , "Michael S. Tsirkin" , Markus Armbruster , Francesco Lavra , Marcelo Tosatti , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Rick Edgecombe Subject: Re: [PATCH v8 13/55] i386/tdx: Support user configurable mrconfigid/mrowner/mrownerconfig Message-ID: References: <20250401130205.2198253-1-xiaoyao.li@intel.com> <20250401130205.2198253-14-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.294, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Apr 23, 2025 at 04:11:25PM +0800, Xiaoyao Li wrote: > On 4/22/2025 11:42 PM, Zhao Liu wrote: > > > diff --git a/qapi/qom.json b/qapi/qom.json > > > index f229bb07aaec..a8379bac1719 100644 > > > --- a/qapi/qom.json > > > +++ b/qapi/qom.json > > > @@ -1060,11 +1060,25 @@ > > > # pages. Some guest OS (e.g., Linux TD guest) may require this to > > > # be set, otherwise they refuse to boot. > > > # > > > +# @mrconfigid: ID for non-owner-defined configuration of the guest TD, > > > +# e.g., run-time or OS configuration (base64 encoded SHA384 digest). > > > +# Defaults to all zeros. > > > > Maybe a typo? s/Defaults/Default/ > > (It) defaults to all zeros. > > If you grep the "defaults to", you can get a lot of it. 'Defaults to' is correct/acceptable terminology, IMHO, no need to change. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|