From: John Levon <john.levon@nutanix.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, "Tony Krowiak" <akrowiak@linux.ibm.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Peter Xu" <peterx@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
qemu-s390x@nongnu.org, "Tomita Moeko" <tomitamoeko@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"John Johnson" <john.g.johnson@oracle.com>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>
Subject: Re: [PATCH 14/14] vfio/container: pass MemoryRegion to DMA operations
Date: Thu, 24 Apr 2025 18:49:53 +0100 [thread overview]
Message-ID: <aAp5wRFPVHZa8qpn@lent> (raw)
In-Reply-To: <ee8e7759-52c6-4681-8369-3c47050d574b@redhat.com>
On Thu, Apr 24, 2025 at 06:32:13PM +0200, Cédric Le Goater wrote:
> > @@ -2250,6 +2251,10 @@ bool memory_get_xlat_addr(IOMMUTLBEntry *iotlb, void **vaddr,
> > *read_only = !writable || mr->readonly;
> > }
> > + if (mrp != NULL) {
> > + *mrp = mr;
> > + }
> > +
> > return true;
> > }
>
> Is everyone OK with adding an extra in/out parameter to memory_get_xlat_addr() ?
> Should we take a ref on the region ?
>
> I think this change should be proposed in its own patch as done in the previous
> series and by Steve for live update.
Yep, I left this one last as I think it's best picked up by someone who
understands this a lot better than me!
regards
john
next prev parent reply other threads:[~2025-04-24 17:51 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 13:48 [PATCH 00/14] vfio: preparation for vfio-user John Levon
2025-04-09 13:48 ` [PATCH 01/14] vfio: refactor out vfio_interrupt_setup() John Levon
2025-04-23 12:20 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 02/14] vfio: refactor out vfio_pci_config_setup() John Levon
2025-04-09 15:38 ` Tomita Moeko
2025-04-09 15:41 ` John Levon
2025-04-09 13:48 ` [PATCH 03/14] vfio: add vfio_prepare_device() John Levon
2025-04-23 12:45 ` Cédric Le Goater
2025-04-23 13:19 ` John Levon
2025-04-09 13:48 ` [PATCH 04/14] vfio: add vfio_attach_device_by_iommu_type() John Levon
2025-04-23 13:25 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 05/14] vfio/container: pass listener_begin/commit callbacks John Levon
2025-04-23 13:45 ` Cédric Le Goater
2025-04-24 16:24 ` Cédric Le Goater
2025-04-24 16:28 ` John Levon
2025-04-24 16:35 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 06/14] vfio: add flags parameter to DMA unmap callback John Levon
2025-04-09 13:48 ` [PATCH 07/14] vfio: specify VFIO_DMA_UNMAP_FLAG_ALL to callback John Levon
2025-04-23 17:01 ` Cédric Le Goater
2025-04-23 17:17 ` John Levon
2025-04-24 17:16 ` Cédric Le Goater
2025-04-24 19:35 ` John Levon
2025-04-28 11:41 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 08/14] vfio: add vfio-pci-base class John Levon
2025-04-24 15:17 ` Cédric Le Goater
2025-04-24 21:52 ` John Levon
2025-04-25 12:46 ` Cédric Le Goater
2025-04-25 13:01 ` John Levon
2025-04-28 12:53 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 09/14] vfio: add vfio_device_get_irq_info() helper John Levon
2025-04-23 17:16 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 10/14] vfio: consistently handle return value for helpers John Levon
2025-04-24 15:19 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 11/14] vfio: add vfio_pci_config_space_read/write() John Levon
2025-04-09 15:51 ` Tomita Moeko
2025-04-09 15:54 ` John Levon
2025-04-09 16:30 ` Tomita Moeko
2025-04-24 15:59 ` Cédric Le Goater
2025-04-24 16:06 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 12/14] vfio: add region info cache John Levon
2025-04-24 16:08 ` Cédric Le Goater
2025-04-24 16:26 ` John Levon
2025-04-28 15:16 ` Cédric Le Goater
2025-04-28 15:26 ` John Levon
2025-04-28 15:39 ` Cédric Le Goater
2025-04-28 16:09 ` John Levon
2025-04-29 22:41 ` John Levon
2025-04-09 13:48 ` [PATCH 13/14] vfio: add device IO ops vector John Levon
2025-04-24 16:18 ` Cédric Le Goater
2025-04-09 13:48 ` [PATCH 14/14] vfio/container: pass MemoryRegion to DMA operations John Levon
2025-04-24 16:32 ` Cédric Le Goater
2025-04-24 17:49 ` John Levon [this message]
2025-04-25 7:59 ` [PATCH 00/14] vfio: preparation for vfio-user Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAp5wRFPVHZa8qpn@lent \
--to=john.levon@nutanix.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=farman@linux.ibm.com \
--cc=jag.raman@oracle.com \
--cc=jjherne@linux.ibm.com \
--cc=john.g.johnson@oracle.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=thuth@redhat.com \
--cc=tomitamoeko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).