From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1BE0C3ABBC for ; Fri, 9 May 2025 09:10:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uDJka-0006zw-Kq; Fri, 09 May 2025 05:10:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDJkB-0006gn-TY; Fri, 09 May 2025 05:10:13 -0400 Received: from mgamail.intel.com ([198.175.65.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDJk8-0000bJ-Po; Fri, 09 May 2025 05:10:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746781809; x=1778317809; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=UxsyZzWNkwrxjYcXBWnFnM0Egm8Nx5UTD5jcKBNb4Es=; b=bBLAaoFiAlb1VD9bprFAvhes+0ku8TQvPGKJZJ/y5hOfq+p3M/0Dzi7J GL3YHt9VU7ALGTkF4M6MTBuOEiONhmEQEgkySf7zRHKH9M2+cjm2gFZ1e At+NjBLxqQxqQYVwLy6uN21hrxkvbvsTTn0hfVIH4x88Hgv5IZtpnncuA 1n5sELhEWT7SurVc8ZIuF6aHv399cib/zylauc6HYRi/P4M0tB+Q06yzF xY3n4zxD1nEqCwlHHM3ggO2pgVRg3oJv2zFJU/uzRBI+MVoc1o1CPMLBC KRwhrkTOZrRh9KmUn/3fy4jtInUgNyIbYtdfbfv4+VaehtAk9HOZrJZob A==; X-CSE-ConnectionGUID: 5lsETuMZS3CAs+5ttEwolQ== X-CSE-MsgGUID: 1oGu9DhpSWahK5PmokJctA== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="60004058" X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="60004058" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 02:10:03 -0700 X-CSE-ConnectionGUID: q2n6DGcgQ961UrU2zD5Opg== X-CSE-MsgGUID: ixYYo8l2QHy72d+IpCL59A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="136952061" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by fmviesa008.fm.intel.com with ESMTP; 09 May 2025 02:09:56 -0700 Date: Fri, 9 May 2025 17:30:58 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Igor Mammedov , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?iso-8859-1?Q?Cl=E9ment?= Mathieu--Drif , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Huacai Chen , Jason Wang , Mark Cave-Ayland , Thomas Huth Subject: Re: [PATCH v4 14/27] hw/intc/apic: Remove APICCommonState::legacy_instance_id field Message-ID: References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-15-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250508133550.81391-15-philmd@linaro.org> Received-SPF: pass client-ip=198.175.65.12; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -57 X-Spam_score: -5.8 X-Spam_bar: ----- X-Spam_report: (-5.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.416, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, May 08, 2025 at 03:35:37PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:37 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 14/27] hw/intc/apic: Remove > APICCommonState::legacy_instance_id field > X-Mailer: git-send-email 2.47.1 > > The APICCommonState::legacy_instance_id boolean was only set > in the pc_compat_2_6[] array, via the 'legacy-instance-id=on' > property. We removed all machines using that array, lets remove > that property, simplifying apic_common_realize(). > > Because instance_id is initialized as initial_apic_id, we can > not register vmstate_apic_common directly via dc->vmsd. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Mark Cave-Ayland > Reviewed-by: Thomas Huth > --- > include/hw/i386/apic_internal.h | 1 - > hw/intc/apic_common.c | 5 ----- > 2 files changed, 6 deletions(-) Reviewed-by: Zhao Liu