* [PATCH] target/i386/hvf: fix a compilation error
@ 2025-04-29 6:24 Wei Liu
2025-04-29 6:52 ` Philippe Mathieu-Daudé
2025-04-29 8:56 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Wei Liu @ 2025-04-29 6:24 UTC (permalink / raw)
To: qemu-devel; +Cc: Wei Liu, Cameron Esfahani, Roman Bolshakov, Phil Dennis-Jordan
Include exec/target_page.h to fix the following build error.
x86_64-softmmu.a.p/target_i386_hvf_hvf.c.o -c ../target/i386/hvf/hvf.c
../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
139 | uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
| ^
../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
141 | hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
| ^
Signed-off-by: Wei Liu <wei.liu@kernel.org>
---
I suspect 58d00538ceeef990 and its follow-up patches caused this issue but I
unfortunately don't have cycles to investigate further.
---
target/i386/hvf/hvf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 23ebf2550a..99e37a33e5 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -76,6 +76,7 @@
#include "qemu/main-loop.h"
#include "qemu/accel.h"
#include "target/i386/cpu.h"
+#include "exec/target_page.h"
static Error *invtsc_mig_blocker;
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/i386/hvf: fix a compilation error
2025-04-29 6:24 [PATCH] target/i386/hvf: fix a compilation error Wei Liu
@ 2025-04-29 6:52 ` Philippe Mathieu-Daudé
2025-04-29 8:56 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-29 6:52 UTC (permalink / raw)
To: Wei Liu, qemu-devel; +Cc: Cameron Esfahani, Roman Bolshakov, Phil Dennis-Jordan
On 29/4/25 08:24, Wei Liu wrote:
> Include exec/target_page.h to fix the following build error.
>
> x86_64-softmmu.a.p/target_i386_hvf_hvf.c.o -c ../target/i386/hvf/hvf.c
> ../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> 139 | uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
> | ^
> ../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> 141 | hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
> | ^
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> I suspect 58d00538ceeef990 and its follow-up patches caused this issue but I
> unfortunately don't have cycles to investigate further.
Yeah sorry we don't have HVF intel covered anymore in our CI so we
missed this. It is due to commit 9c2ff9cdc9b, see same fix:
https://lore.kernel.org/qemu-devel/20250425174310.70890-1-philmd@linaro.org/
> ---
> target/i386/hvf/hvf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
> index 23ebf2550a..99e37a33e5 100644
> --- a/target/i386/hvf/hvf.c
> +++ b/target/i386/hvf/hvf.c
> @@ -76,6 +76,7 @@
> #include "qemu/main-loop.h"
> #include "qemu/accel.h"
> #include "target/i386/cpu.h"
> +#include "exec/target_page.h"
>
> static Error *invtsc_mig_blocker;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/i386/hvf: fix a compilation error
2025-04-29 6:24 [PATCH] target/i386/hvf: fix a compilation error Wei Liu
2025-04-29 6:52 ` Philippe Mathieu-Daudé
@ 2025-04-29 8:56 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2025-04-29 8:56 UTC (permalink / raw)
To: Wei Liu; +Cc: qemu-devel, Cameron Esfahani, Roman Bolshakov, Phil Dennis-Jordan
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-29 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29 6:24 [PATCH] target/i386/hvf: fix a compilation error Wei Liu
2025-04-29 6:52 ` Philippe Mathieu-Daudé
2025-04-29 8:56 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).