From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Brad Smith" <brad@comstyle.com>,
qemu-devel@nongnu.org, "Warner Losh" <imp@bsdimp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH 2/5] hw/display/bcm2835_fb: Move inclusion of console.h to the .c file
Date: Thu, 8 May 2025 19:24:59 +0100 [thread overview]
Message-ID: <aBz2--84VeQceAGi@redhat.com> (raw)
In-Reply-To: <20250508144120.163009-3-thuth@redhat.com>
On Thu, May 08, 2025 at 04:41:17PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> The definitions from console.h are not needed in the bcm2835_fb.h
> header file yet, so let's move it to the place that really needs
> its definitions, i.e. into the bcm2835_fb.c file.
> This way the header can also be used by code that is not compiled
> with the CFLAGS that are required for pixman or OpenGL (in case
> their headers do not reside under /usr/include).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> include/hw/display/bcm2835_fb.h | 1 -
> hw/display/bcm2835_fb.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
It references the QemuConsole type, but we get that from typedefs.h
not console.h so
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-05-08 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 14:41 [PATCH RESEND 0/5] Fix dependencies in arm machines and update OpenBSD to 7.7 Thomas Huth
2025-05-08 14:41 ` [PATCH 1/5] include/hw/dma/xlnx_dpdma: Remove dependency on console.h Thomas Huth
2025-05-08 15:39 ` Philippe Mathieu-Daudé
2025-05-08 14:41 ` [PATCH 2/5] hw/display/bcm2835_fb: Move inclusion of console.h to the .c file Thomas Huth
2025-05-08 18:24 ` Daniel P. Berrangé [this message]
2025-05-08 14:41 ` [RFC PATCH 3/5] hw/arm: Compile musicpal and the xlnx machines with the right CFLAGS Thomas Huth
2025-05-08 14:41 ` [PATCH 4/5] tests/vm: Update OpenBSD to 7.7 Thomas Huth
2025-05-08 18:25 ` Daniel P. Berrangé
2025-05-08 14:41 ` [RFC PATCH 5/5] Revert "meson.build: Disable -fzero-call-used-regs on OpenBSD" Thomas Huth
2025-05-08 18:26 ` Daniel P. Berrangé
2025-09-09 7:30 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBz2--84VeQceAGi@redhat.com \
--to=berrange@redhat.com \
--cc=brad@comstyle.com \
--cc=imp@bsdimp.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).