From: Peter Xu <peterx@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
"Fabiano Rosas" <farosas@suse.de>,
"Cédric Le Goater" <clg@redhat.com>,
"Joao Martins" <joao.m.martins@oracle.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH] migration/multifd: Don't send device state packets with zerocopy flag
Date: Thu, 22 May 2025 16:45:53 -0400 [thread overview]
Message-ID: <aC-NAZEznD1gvJ3r@x1.local> (raw)
In-Reply-To: <4a5a68dd-74b2-4ffc-baa7-42eba9276b81@tls.msk.ru>
On Thu, May 22, 2025 at 11:12:22PM +0300, Michael Tokarev wrote:
> On 16.05.2025 16:53, Maciej S. Szmigiero wrote:
> > From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
> >
> > If zerocopy is enabled for multifd then QIO_CHANNEL_WRITE_FLAG_ZERO_COPY
> > flag is forced into all multifd channel write calls via p->write_flags
> > that was setup in multifd_nocomp_send_setup().
> >
> > However, device state packets aren't compatible with zerocopy - the data
> > buffer isn't getting kept pinned until multifd channel flush.
> >
> > Make sure to mask that QIO_CHANNEL_WRITE_FLAG_ZERO_COPY flag in a multifd
> > send thread if the data being sent is device state.
> >
> > Fixes: 0525b91a0b99 ("migration/multifd: Device state transfer support - send side")
> > Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
>
> Is this qemu-stable material (for 10.0)?
>
> I'm picking it up for 10.0 branch, please let me know if I shouldn't.
Yes please, for two migration patches in the lastest pull. I forgot to add
Cc: for stable. I'll try to remember again, thanks.
--
Peter Xu
prev parent reply other threads:[~2025-05-22 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 13:53 [PATCH] migration/multifd: Don't send device state packets with zerocopy flag Maciej S. Szmigiero
2025-05-16 14:39 ` Fabiano Rosas
2025-05-16 16:54 ` Peter Xu
2025-05-22 20:12 ` Michael Tokarev
2025-05-22 20:45 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC-NAZEznD1gvJ3r@x1.local \
--to=peterx@redhat.com \
--cc=clg@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=farosas@suse.de \
--cc=joao.m.martins@oracle.com \
--cc=mail@maciej.szmigiero.name \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).